third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h - Issue 2416843002: Implement FetchEvent.navigationPreload

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h

Issue 2416843002: Implement FetchEvent.navigationPreload (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp ('K') | « third_party/WebKit/Source/modules/serviceworkers/FetchEvent.idl ('k') | third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.h » ('j') | third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h

diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h

index 524133ac757f2e09e42b575b47d69708b2dc79c3..40f07466c7d1e25da03e10e06b3b23b6db08d6a5 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h

+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h

@@ -38,6 +38,7 @@

#include "public/platform/modules/serviceworker/WebServiceWorkerClientsClaimCallbacks.h"

#include "public/platform/modules/serviceworker/WebServiceWorkerClientsInfo.h"

#include "public/platform/modules/serviceworker/WebServiceWorkerEventResult.h"

+#include "public/platform/modules/serviceworker/WebServiceWorkerPreloadResponseCallbacks.h"

#include "public/platform/modules/serviceworker/WebServiceWorkerSkipWaitingCallbacks.h"

#include "wtf/Forward.h"

#include "wtf/Noncopyable.h"

@@ -124,6 +125,10 @@ class MODULES_EXPORT ServiceWorkerGlobalScopeClient

const WebVector<WebURL>& subScopes,

const WebVector<WebSecurityOrigin>&) = 0;

+ virtual void registerPreloadResponseCallback(

falken 2016/10/19 06:00:13 I think it's time to break the pattern of no comme

horo 2016/10/19 07:11:45 Done.

+ int eventID,

+ WebServiceWorkerPreloadResponseCallbacks*) = 0;

falken 2016/10/19 06:00:13 Could this be std::unique_ptr (I think previously

horo 2016/10/19 07:11:45 Done.

static const char* supplementName();

static ServiceWorkerGlobalScopeClient* from(ExecutionContext*);