Implement FetchEvent.navigationPreload

third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h

 /*
  * Copyright (C) 2014 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 20 matching lines @@
 #ifndef ServiceWorkerGlobalScopeClient_h
 #define ServiceWorkerGlobalScopeClient_h
 
 #include "core/dom/MessagePort.h"
 #include "core/workers/WorkerClients.h"
 #include "modules/ModulesExport.h"
 #include "public/platform/WebMessagePortChannel.h"
 #include "public/platform/modules/serviceworker/WebServiceWorkerClientsClaimCallbacks.h"
 #include "public/platform/modules/serviceworker/WebServiceWorkerClientsInfo.h"
 #include "public/platform/modules/serviceworker/WebServiceWorkerEventResult.h"
+#include "public/platform/modules/serviceworker/WebServiceWorkerPreloadResponseCallbacks.h"
 #include "public/platform/modules/serviceworker/WebServiceWorkerSkipWaitingCallbacks.h"
 #include "wtf/Forward.h"
 #include "wtf/Noncopyable.h"
 #include <memory>
 
 namespace blink {
 
 struct WebCrossOriginServiceWorkerClient;
 struct WebServiceWorkerClientQueryOptions;
 class ExecutionContext;
@@ skipping 66 matching lines @@
   virtual void claim(WebServiceWorkerClientsClaimCallbacks*) = 0;
   virtual void focus(const WebString& clientUUID,
                      WebServiceWorkerClientCallbacks*) = 0;
   virtual void navigate(const WebString& clientUUID,
                         const WebURL&,
                         WebServiceWorkerClientCallbacks*) = 0;
   virtual void registerForeignFetchScopes(
       const WebVector<WebURL>& subScopes,
       const WebVector<WebSecurityOrigin>&) = 0;
 
+  virtual void registerPreloadResponseCallback(

[falken, 2016/10/19 06:00:13]

I think it's time to break the pattern of no comments in this file :)
Can you add a brief comment like "Registers the callback used to settle the
FetchEvent.navigationPreload promise"?

[horo, 2016/10/19 07:11:45]

Done.

+      int eventID,
+      WebServiceWorkerPreloadResponseCallbacks*) = 0;

[falken, 2016/10/19 06:00:13]

Could this be std::unique_ptr (I think previously we couldn't until yutak's work
migrating OwnPtr to unique_ptr)

[horo, 2016/10/19 07:11:45]

Done.

+
   static const char* supplementName();
   static ServiceWorkerGlobalScopeClient* from(ExecutionContext*);
 
  protected:
   ServiceWorkerGlobalScopeClient() {}
 };
 
 MODULES_EXPORT void provideServiceWorkerGlobalScopeClientToWorker(
     WorkerClients*,
     ServiceWorkerGlobalScopeClient*);
 
 }  // namespace blink
 
 #endif  // ServiceWorkerGlobalScopeClient_h