Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2416623003: M55: Revert r414590 (Closed)

Created:
4 years, 2 months ago by Lei Zhang
Modified:
4 years, 2 months ago
Reviewers:
tkent, iclelland, jwd, lunalu1
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

M55: Revert r414590 Fixed the behaviour of form submit to match the standard: no submit is taken place when the form is detached from the document (e.g., form is removed). Reason for revert: Broke Cloud Print print job upload form. BUG=586749, 653692 TBR=lunalu@chromium.org,tkent@chromium.org,jwd@chromium.org,iclelland@chromium.org Original code review: https://codereview.chromium.org/2261393002 Review-Url: https://codereview.chromium.org/2409863002 Cr-Commit-Position: refs/heads/master@{#424328} (cherry picked from commit 005750463baa9ec11ff139b5256f78eec8e6510f) Committed: https://chromium.googlesource.com/chromium/src/+/94272796d09c2055db4d1ff48de2258fb9c608d0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -36 lines) Patch
D third_party/WebKit/LayoutTests/fast/forms/submit-form-not-attached-to-document.html View 1 chunk +0 lines, -24 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/cookies/same-site/popup-cross-site-post.html View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/cookies/same-site/popup-same-site-post.html View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFormElement.cpp View 1 chunk +2 lines, -5 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
Lei Zhang
Committed patchset #1 (id:1) manually as 94272796d09c2055db4d1ff48de2258fb9c608d0.
4 years, 2 months ago (2016-10-12 18:43:25 UTC) #2
tkent
4 years, 2 months ago (2016-10-12 22:54:12 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698