Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2409863002: Revert r414590 (Closed)

Created:
4 years, 2 months ago by Lei Zhang
Modified:
4 years, 2 months ago
Reviewers:
tkent, iclelland, jwd, lunalu1, ojan
CC:
tkent, asvitkine+watch_chromium.org, blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, iclelland, lulanu_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert r414590 Fixed the behaviour of form submit to match the standard: no submit is taken place when the form is detached from the document (e.g., form is removed). Reason for revert: Broke Cloud Print print job upload form. BUG=586749, 653692 TBR=lunalu@chromium.org,tkent@chromium.org,jwd@chromium.org,iclelland@chromium.org Original code review: https://codereview.chromium.org/2261393002 Committed: https://crrev.com/005750463baa9ec11ff139b5256f78eec8e6510f Cr-Commit-Position: refs/heads/master@{#424328}

Patch Set 1 #

Patch Set 2 : delete #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -36 lines) Patch
D third_party/WebKit/LayoutTests/fast/forms/submit-form-not-attached-to-document.html View 1 1 chunk +0 lines, -24 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/cookies/same-site/popup-cross-site-post.html View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/cookies/same-site/popup-same-site-post.html View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFormElement.cpp View 1 chunk +2 lines, -5 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (13 generated)
ojan
lgtm to get the release fixed. Next steps for this is to make a repro ...
4 years, 2 months ago (2016-10-10 23:43:16 UTC) #6
Lei Zhang
TBRing original reviewers.
4 years, 2 months ago (2016-10-10 23:44:27 UTC) #8
Lei Zhang
TBR See ojan's comment for next steps.
4 years, 2 months ago (2016-10-10 23:45:44 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2409863002/20001
4 years, 2 months ago (2016-10-11 01:15:36 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-11 01:24:08 UTC) #17
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/005750463baa9ec11ff139b5256f78eec8e6510f Cr-Commit-Position: refs/heads/master@{#424328}
4 years, 2 months ago (2016-10-11 01:27:34 UTC) #19
tkent
lgtm
4 years, 2 months ago (2016-10-11 13:39:04 UTC) #20
lunalu1
4 years, 2 months ago (2016-10-11 14:17:03 UTC) #21
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698