Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2416533003: Remove usage of base::ObserverList<T>::Iter::GetNext() in //chrome. (Closed)

Created:
4 years, 2 months ago by dcheng
Modified:
4 years, 2 months ago
Reviewers:
ncarter (slow)
CC:
chromium-reviews, loyso (OOO)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove usage of base::ObserverList<T>::Iter::GetNext() in //chrome. Observer lists now support range-based for loops. BUG=655021 Committed: https://crrev.com/ea68766deda7cb89f2f08e1ca816f9666a95c3bd Cr-Commit-Position: refs/heads/master@{#425066}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M chrome/browser/task_manager/task_manager_interface.cc View 2 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
dcheng
4 years, 2 months ago (2016-10-12 22:54:12 UTC) #4
ncarter (slow)
lgtm
4 years, 2 months ago (2016-10-13 16:53:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2416533003/1
4 years, 2 months ago (2016-10-13 16:54:12 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-13 17:00:16 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 17:02:45 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ea68766deda7cb89f2f08e1ca816f9666a95c3bd
Cr-Commit-Position: refs/heads/master@{#425066}

Powered by Google App Engine
This is Rietveld 408576698