Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7913)

Unified Diff: chrome/browser/task_manager/task_manager_interface.cc

Issue 2416533003: Remove usage of base::ObserverList<T>::Iter::GetNext() in //chrome. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/task_manager/task_manager_interface.cc
diff --git a/chrome/browser/task_manager/task_manager_interface.cc b/chrome/browser/task_manager/task_manager_interface.cc
index 624f241b78e940339383d776da971db4877a1a68..9cdecf1ee89a7c7fce1e20ccc7ed2cee25bfadcf 100644
--- a/chrome/browser/task_manager/task_manager_interface.cc
+++ b/chrome/browser/task_manager/task_manager_interface.cc
@@ -76,12 +76,11 @@ void TaskManagerInterface::RemoveObserver(TaskManagerObserver* observer) {
// Recalculate the minimum refresh rate and the enabled resource flags.
int64_t flags = 0;
base::TimeDelta min_time = base::TimeDelta::Max();
- base::ObserverList<TaskManagerObserver>::Iterator itr(&observers_);
- while (TaskManagerObserver* obs = itr.GetNext()) {
- if (obs->desired_refresh_time() < min_time)
- min_time = obs->desired_refresh_time();
+ for (auto& observer : observers_) {
+ if (observer.desired_refresh_time() < min_time)
+ min_time = observer.desired_refresh_time();
- flags |= obs->desired_resources_flags();
+ flags |= observer.desired_resources_flags();
}
if (min_time == base::TimeDelta::Max()) {
@@ -97,9 +96,8 @@ void TaskManagerInterface::RemoveObserver(TaskManagerObserver* observer) {
void TaskManagerInterface::RecalculateRefreshFlags() {
int64_t flags = 0;
- base::ObserverList<TaskManagerObserver>::Iterator itr(&observers_);
- while (TaskManagerObserver* obs = itr.GetNext())
- flags |= obs->desired_resources_flags();
+ for (auto& observer : observers_)
+ flags |= observer.desired_resources_flags();
SetEnabledResourceFlags(flags);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698