Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1442)

Issue 2416483002: Use std::string instead of mojo::String in //net. (Closed)

Created:
4 years, 2 months ago by Sam McNally
Modified:
4 years, 2 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use std::string instead of mojo::String in //net. BUG=624136 Committed: https://crrev.com/f75fab282856968be1614a3fc876812e9fdf2788 Cr-Commit-Position: refs/heads/master@{#424888}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -57 lines) Patch
M chrome/browser/net/utility_process_mojo_proxy_resolver_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/utility_process_mojo_proxy_resolver_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M net/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M net/interfaces/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M net/proxy/in_process_mojo_proxy_resolver_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/in_process_mojo_proxy_resolver_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/mojo_proxy_resolver_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/mojo_proxy_resolver_factory_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/mojo_proxy_resolver_factory_impl.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M net/proxy/mojo_proxy_resolver_factory_impl_unittest.cc View 5 chunks +6 lines, -10 lines 0 comments Download
M net/proxy/mojo_proxy_resolver_impl_unittest.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M net/proxy/mojo_proxy_resolver_v8_tracing_bindings.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/proxy/mojo_proxy_resolver_v8_tracing_bindings_unittest.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M net/proxy/proxy_resolver_factory_mojo.cc View 4 chunks +11 lines, -11 lines 0 comments Download
M net/proxy/proxy_resolver_factory_mojo_unittest.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M net/proxy/proxy_service_mojo_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
Sam McNally
4 years, 2 months ago (2016-10-12 04:28:52 UTC) #5
eroman
lgtm
4 years, 2 months ago (2016-10-12 22:10:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2416483002/1
4 years, 2 months ago (2016-10-12 22:29:03 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-12 22:38:00 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 22:40:28 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f75fab282856968be1614a3fc876812e9fdf2788
Cr-Commit-Position: refs/heads/master@{#424888}

Powered by Google App Engine
This is Rietveld 408576698