net/proxy/in_process_mojo_proxy_resolver_factory.cc - Issue 2416483002: Use std::string instead of mojo::String in //net.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/proxy/in_process_mojo_proxy_resolver_factory.cc

Issue 2416483002: Use std::string instead of mojo::String in //net. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/proxy/in_process_mojo_proxy_resolver_factory.cc

diff --git a/net/proxy/in_process_mojo_proxy_resolver_factory.cc b/net/proxy/in_process_mojo_proxy_resolver_factory.cc

index 2f04b241d07b4563b3837ee1fc1131b4c89107fb..5c3920a005bab05dd90cd2998b0af543106f0bf3 100644

--- a/net/proxy/in_process_mojo_proxy_resolver_factory.cc

+++ b/net/proxy/in_process_mojo_proxy_resolver_factory.cc

@@ -28,7 +28,7 @@ InProcessMojoProxyResolverFactory::~InProcessMojoProxyResolverFactory() =

std::unique_ptr<base::ScopedClosureRunner>

InProcessMojoProxyResolverFactory::CreateResolver(

- const mojo::String& pac_script,

+ const std::string& pac_script,

mojo::InterfaceRequest<interfaces::ProxyResolver> req,

interfaces::ProxyResolverFactoryRequestClientPtr client) {

factory_->CreateResolver(pac_script, std::move(req), std::move(client));