Adding Histograms for new Desktop First Run.

Adding Histograms for new Desktop First Run.

BUG=656121, 652345
Committed: https://crrev.com/715136d81a5c442922e63a1ae799c1a2f47091a8
Cr-Commit-Position: refs/heads/master@{#427264}

[tmartino, 2016-10-14 20:13:59]

tmartino@chromium.org changed reviewers:
+ rkaplow@chromium.org

[rkaplow, 2016-10-17 14:02:54]

where is the CL that adds these? They should ideally be in the same CL.

[tmartino, 2016-10-20 20:15:22]

Added calls using one enum. The handlers aren't ready for the others yet, so
I've removed their definitions for a later CL.

[rkaplow, 2016-10-21 15:06:05]

lgtm

https://codereview.chromium.org/2416333003/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/welcome_handler.h (right):

https://codereview.chromium.org/2416333003/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/welcome_handler.h:31: DEFAULT = 0,    // User navigated
away from the page.
small nit - might make more sense for this to NAVIGATED_AWAY?

Up to you

[tmartino, 2016-10-21 18:49:34]

Description was changed from

==========
Adding Histograms for new Desktop First Run.

BUG=656121
==========

to

==========
Adding Histograms for new Desktop First Run.

BUG=656121, 652345
==========

[tmartino, 2016-10-21 18:50:57]

+michaelpg for OWNERS on welcome_handler.*

Thanks, Robert! I added one more user action we need that made sense to wrap up
in this change, so you may want to look over that as well.

https://codereview.chromium.org/2416333003/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/welcome_handler.h (right):

https://codereview.chromium.org/2416333003/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/welcome_handler.h:31: DEFAULT = 0,    // User navigated
away from the page.
On 2016/10/21 at 15:06:05, rkaplow wrote:
> small nit - might make more sense for this to NAVIGATED_AWAY?
> 
> Up to you

IMO DEFAULT makes the most sense. It's only really a proxy for "user navigated
away", and it represents a default in the sense that neither of the other two
events that cause a departure happened before destruct-time.

[tmartino, 2016-10-24 22:04:05]

tmartino@chromium.org changed reviewers:
+ michaelpg@chromium.org

[tmartino, 2016-10-24 22:04:06]

Whoops, didn't actually add michaelpg on the last message like I thought I had!

PTAL at welcome_handler.* for OWNERS.

[michaelpg, 2016-10-24 23:40:32]

welcome_handler.* lgtm

[tmartino, 2016-10-25 02:29:45]

The CQ bit was checked by tmartino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 02:30:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 03:27:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 03:28:00]

Dry run: This issue passed the CQ dry run.

[tmartino, 2016-10-25 03:28:14]

The CQ bit was checked by tmartino@chromium.org

[tmartino, 2016-10-25 03:28:14]

The patchset sent to the CQ was uploaded after l-g-t-m from rkaplow@chromium.org
Link to the patchset: https://codereview.chromium.org/2416333003/#ps40001
(title: "Adding user action for impression")

[commit-bot: I haz the power, 2016-10-25 03:28:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 03:34:41]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-25 03:37:12]

Description was changed from

==========
Adding Histograms for new Desktop First Run.

BUG=656121, 652345
==========

to

==========
Adding Histograms for new Desktop First Run.

BUG=656121, 652345

Committed: https://crrev.com/715136d81a5c442922e63a1ae799c1a2f47091a8
Cr-Commit-Position: refs/heads/master@{#427264}
==========

[commit-bot: I haz the power, 2016-10-25 03:37:13]

Patchset 3 (id:??) landed as
https://crrev.com/715136d81a5c442922e63a1ae799c1a2f47091a8
Cr-Commit-Position: refs/heads/master@{#427264}