Adding Histograms for new Desktop First Run.

chrome/browser/ui/webui/welcome_handler.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_WEBUI_WELCOME_HANDLER_H_
 #define CHROME_BROWSER_UI_WEBUI_WELCOME_HANDLER_H_
 
 #include "base/macros.h"
 #include "content/public/browser/web_ui_message_handler.h"
 #include "google_apis/gaia/oauth2_token_service.h"
@@ skipping 10 matching lines @@
   ~WelcomeHandler() override;
 
   // OAuth2TokenService::Observer:
   void OnRefreshTokenAvailable(const std::string& account_id) override;
 
   // content::WebUIMessageHandler:
   void RegisterMessages() override;
 
  private:
   enum WelcomeResult {
-    DEFAULT = 0,
-    SIGNED_IN,  // User clicked the "Sign In" button and completed sign-in.
-    DECLINED    // User clicked the "No Thanks" button.
+    DEFAULT = 0,    // User navigated away from the page.

[rkaplow, 2016/10/21 15:06:05]

small nit - might make more sense for this to NAVIGATED_AWAY?

Up to you

[tmartino, 2016/10/21 18:50:57]

IMO DEFAULT makes the most sense. It's only really a proxy for "user navigated
away", and it represents a default in the sense that neither of the other two
events that cause a departure happened before destruct-time.

+    DECLINED = 1,   // User clicked the "No Thanks" button.
+    SIGNED_IN = 2,  // User clicked the "Sign In" button and completed sign-in.
+
+    // New results must be added before this line, and should correspond to
+    // values in tools/metrics/histograms/histograms.xml.
+    WELCOME_RESULT_MAX
   };
 
   void HandleActivateSignIn(const base::ListValue* args);
   void HandleUserDecline(const base::ListValue* args);
   void GoToNewTabPage();
 
   Browser* GetBrowser();
 
   Profile* profile_;
   ProfileOAuth2TokenService* oauth2_token_service_;
   WelcomeResult result_;
 
   DISALLOW_COPY_AND_ASSIGN(WelcomeHandler);
 };
 
 #endif  // CHROME_BROWSER_UI_WEBUI_WELCOME_HANDLER_H_