Deprecate PageLoad.Timing2.NavigationToFirstBackground histograms.

Deprecate PageLoad.Timing2.NavigationToFirstBackground histograms.

These histograms have been replaced by
PageLoad.AbortTiming.Background equivalents.

BUG=654430
Committed: https://crrev.com/a614b7ff39b1abb2345b7b79e5d76649bd97dc5f
Cr-Commit-Position: refs/heads/master@{#425544}

[Bryan McQuade, 2016-10-14 16:26:43]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 16:27:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bryan McQuade, 2016-10-14 17:21:37]

Description was changed from

==========
Deprecate PageLoad.Timing2.NavigationToFirstBackground histograms.

These histograms have been replaced by
PageLoad.AbortTiming.Background equivalents.

BUG=
==========

to

==========
Deprecate PageLoad.Timing2.NavigationToFirstBackground histograms.

These histograms have been replaced by
PageLoad.AbortTiming.Background equivalents.

BUG=654430
==========

[Bryan McQuade, 2016-10-14 17:21:48]

bmcquade@chromium.org changed reviewers:
+ csharrison@chromium.org

[Bryan McQuade, 2016-10-14 17:21:49]

PTAL

[commit-bot: I haz the power, 2016-10-14 17:35:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 17:35:06]

Dry run: This issue passed the CQ dry run.

[Charlie Harrison, 2016-10-14 21:31:27]

lg thank you for this cleanup

https://codereview.chromium.org/2416213003/diff/1/chrome/browser/page_load_me...
File
chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
(left):

https://codereview.chromium.org/2416213003/diff/1/chrome/browser/page_load_me...
chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc:386:
TEST_F(CorePageLoadMetricsObserverTest, BackgroundBeforePaint) {
Why remove this test? Can we just update the histogram expectation?

[Bryan McQuade, 2016-10-14 22:40:27]

https://codereview.chromium.org/2416213003/diff/1/chrome/browser/page_load_me...
File
chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
(left):

https://codereview.chromium.org/2416213003/diff/1/chrome/browser/page_load_me...
chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc:386:
TEST_F(CorePageLoadMetricsObserverTest, BackgroundBeforePaint) {
On 2016/10/14 at 21:31:27, Charlie Harrison wrote:
> Why remove this test? Can we just update the histogram expectation?

This test was verifying that kHistogramBackgroundBeforePaint was set. That
histogram is being removed as part of this change. Were you suggesting that I
move this test to the aborts unittest? I already added a test for this case as
part of my earlier background abort change, so I don't think we need to add
anything in that test file.

[Charlie Harrison, 2016-10-14 22:41:59]

Yeah I was just verifying we have a test for the aborts case. LGTM in that case.

[Bryan McQuade, 2016-10-14 22:44:39]

The CQ bit was checked by bmcquade@chromium.org

[Bryan McQuade, 2016-10-14 22:44:47]

The CQ bit was unchecked by bmcquade@chromium.org

[Bryan McQuade, 2016-10-14 22:44:57]

bmcquade@chromium.org changed reviewers:
+ isherman@chromium.org

[Bryan McQuade, 2016-10-14 22:45:06]

isherman, PTAL for histograms.xml, thanks!

[Ilya Sherman, 2016-10-14 23:40:03]

histograms.xml lgtm

[Bryan McQuade, 2016-10-15 03:05:40]

The CQ bit was checked by bmcquade@chromium.org

[commit-bot: I haz the power, 2016-10-15 03:05:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-15 03:13:01]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-15 03:15:31]

Description was changed from

==========
Deprecate PageLoad.Timing2.NavigationToFirstBackground histograms.

These histograms have been replaced by
PageLoad.AbortTiming.Background equivalents.

BUG=654430
==========

to

==========
Deprecate PageLoad.Timing2.NavigationToFirstBackground histograms.

These histograms have been replaced by
PageLoad.AbortTiming.Background equivalents.

BUG=654430

Committed: https://crrev.com/a614b7ff39b1abb2345b7b79e5d76649bd97dc5f
Cr-Commit-Position: refs/heads/master@{#425544}
==========

[commit-bot: I haz the power, 2016-10-15 03:15:32]

Patchset 1 (id:??) landed as
https://crrev.com/a614b7ff39b1abb2345b7b79e5d76649bd97dc5f
Cr-Commit-Position: refs/heads/master@{#425544}