Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Unified Diff: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc

Issue 2416213003: Deprecate PageLoad.Timing2.NavigationToFirstBackground histograms. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
diff --git a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
index b64afce58593c94b73e1ab881b3d198fdbf553df..b36d82e0d1e99249a77391ed0845257483a75a9b 100644
--- a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
+++ b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
@@ -383,23 +383,6 @@ TEST_F(CorePageLoadMetricsObserverTest, FailedBackgroundProvisionalLoad) {
0);
}
-TEST_F(CorePageLoadMetricsObserverTest, BackgroundBeforePaint) {
Charlie Harrison 2016/10/14 21:31:27 Why remove this test? Can we just update the histo
Bryan McQuade 2016/10/14 22:40:27 This test was verifying that kHistogramBackgroundB
- page_load_metrics::PageLoadTiming timing;
- timing.navigation_start = base::Time::FromDoubleT(1);
- timing.first_paint = base::TimeDelta::FromSeconds(10);
- PopulateRequiredTimingFields(&timing);
- NavigateAndCommit(GURL(kDefaultTestUrl));
- // Background the tab and go for a coffee or something.
- web_contents()->WasHidden();
- SimulateTimingUpdate(timing);
- // Come back and start browsing again.
- web_contents()->WasShown();
- // Simulate the user performaning another navigation.
- NavigateAndCommit(GURL("https://www.example.com"));
- histogram_tester().ExpectTotalCount(internal::kHistogramBackgroundBeforePaint,
- 1);
-}
-
TEST_F(CorePageLoadMetricsObserverTest, NoRappor) {
rappor::TestSample::Shadow* sample_obj =
rappor_tester_.GetRecordedSampleForMetric(
« no previous file with comments | « chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698