Automation should fire focus event on root view of widgets

Automation should fire focus event on root view of widgets

If a widget has focus, but no view within that widget is focused, report
the root view as the view that's focused for the purposes of firing
focus change events.

BUG=656103
TESTED=Before this change, Alt+Shift+N results in no focus event sent to ChromeVox. After this change, ChromeVox gets a focus event on a node with role=dialog.

Committed: https://crrev.com/33da1a9126ec165972482429ca942a2009d5b66e
Cr-Commit-Position: refs/heads/master@{#427103}

[dmazzoni, 2016-10-14 19:21:07]

dmazzoni@chromium.org changed reviewers:
+ dtseng@chromium.org

[David Tseng, 2016-10-14 21:30:26]

lgtm

SEems fine, but notifications (alt+shift+n) does give a "client" node focus on
TOT. Can you update with TEST= and a case where this gets exercised?

[dmazzoni, 2016-10-19 18:20:27]

Description was changed from

==========
Automation should fire focus event on root view of widgets

If a widget has focus, but no view within that widget is focused, report
the root view as the view that's focused for the purposes of firing
focus change events.

BUG=656103
==========

to

==========
Automation should fire focus event on root view of widgets

If a widget has focus, but no view within that widget is focused, report
the root view as the view that's focused for the purposes of firing
focus change events.

BUG=656103
TESTED=Before this change, Alt+Shift+N results in no focus event sent to
ChromeVox. After this change, ChromeVox gets a focus event on a node with
role=dialog.
==========

[dmazzoni, 2016-10-19 18:22:09]

I can't confirm that we get a focus event on an object
with role=focus. I just tested it again. Before this
change ChromeVox gets no focus event when you press
Alt+Shift+N, and with this change it gets a focus
event on an object with role=dialog.

I didn't have any notifications in the notification
window. Perhaps the result is different if you have
a notification? Either way this seems like a
reasonable change to make to improve the case when
the notifications dialog is empty.

[dmazzoni, 2016-10-19 18:22:14]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2016-10-19 18:22:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 20:04:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 20:04:28]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dmazzoni, 2016-10-21 22:39:42]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2016-10-21 22:40:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-22 00:40:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-22 00:40:33]

Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[dmazzoni, 2016-10-24 17:33:40]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2016-10-24 17:33:40]

The patchset sent to the CQ was uploaded after l-g-t-m from dtseng@chromium.org
Link to the patchset: https://codereview.chromium.org/2416103003/#ps20001
(title: "Update spoken feedback browser tests")

[commit-bot: I haz the power, 2016-10-24 17:34:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 18:41:59]

Description was changed from

==========
Automation should fire focus event on root view of widgets

If a widget has focus, but no view within that widget is focused, report
the root view as the view that's focused for the purposes of firing
focus change events.

BUG=656103
TESTED=Before this change, Alt+Shift+N results in no focus event sent to
ChromeVox. After this change, ChromeVox gets a focus event on a node with
role=dialog.
==========

to

==========
Automation should fire focus event on root view of widgets

If a widget has focus, but no view within that widget is focused, report
the root view as the view that's focused for the purposes of firing
focus change events.

BUG=656103
TESTED=Before this change, Alt+Shift+N results in no focus event sent to
ChromeVox. After this change, ChromeVox gets a focus event on a node with
role=dialog.
==========

[commit-bot: I haz the power, 2016-10-24 18:42:00]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-24 18:54:10]

Description was changed from

==========
Automation should fire focus event on root view of widgets

If a widget has focus, but no view within that widget is focused, report
the root view as the view that's focused for the purposes of firing
focus change events.

BUG=656103
TESTED=Before this change, Alt+Shift+N results in no focus event sent to
ChromeVox. After this change, ChromeVox gets a focus event on a node with
role=dialog.
==========

to

==========
Automation should fire focus event on root view of widgets

If a widget has focus, but no view within that widget is focused, report
the root view as the view that's focused for the purposes of firing
focus change events.

BUG=656103
TESTED=Before this change, Alt+Shift+N results in no focus event sent to
ChromeVox. After this change, ChromeVox gets a focus event on a node with
role=dialog.

Committed: https://crrev.com/33da1a9126ec165972482429ca942a2009d5b66e
Cr-Commit-Position: refs/heads/master@{#427103}
==========

[commit-bot: I haz the power, 2016-10-24 18:54:12]

Patchset 2 (id:??) landed as
https://crrev.com/33da1a9126ec165972482429ca942a2009d5b66e
Cr-Commit-Position: refs/heads/master@{#427103}