Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4990)

Unified Diff: chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc

Issue 2416103003: Automation should fire focus event on root view of widgets (Closed)
Patch Set: Update spoken feedback browser tests Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/views/accessibility/ax_aura_obj_cache.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc
diff --git a/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc b/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc
index bd2b3a9ef73df9b0705776342697d481c6e83b53..9ed18565e30864b72dca4e02dffd957641312ac9 100644
--- a/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc
+++ b/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc
@@ -344,7 +344,11 @@ IN_PROC_BROWSER_TEST_P(SpokenFeedbackTest, FocusShelf) {
EnableChromeVox();
EXPECT_TRUE(PerformAcceleratorAction(ash::FOCUS_SHELF));
- EXPECT_EQ("Launcher", speech_monitor_.GetNextUtterance());
+ while (true) {
+ std::string utterance = speech_monitor_.GetNextUtterance();
+ if (base::MatchPattern(utterance, "Launcher"))
+ break;
+ }
EXPECT_EQ("Button", speech_monitor_.GetNextUtterance());
EXPECT_EQ("Shelf", speech_monitor_.GetNextUtterance());
@@ -414,10 +418,11 @@ IN_PROC_BROWSER_TEST_P(SpokenFeedbackTest, OpenStatusTray) {
EnableChromeVox();
EXPECT_TRUE(PerformAcceleratorAction(ash::SHOW_SYSTEM_TRAY_BUBBLE));
- EXPECT_TRUE(base::MatchPattern(speech_monitor_.GetNextUtterance(), "*"));
- EXPECT_TRUE(base::MatchPattern(speech_monitor_.GetNextUtterance(), "Button"));
- EXPECT_TRUE(
- base::MatchPattern(speech_monitor_.GetNextUtterance(), "Status tray*"));
+ while (true) {
+ std::string utterance = speech_monitor_.GetNextUtterance();
+ if (base::MatchPattern(utterance, "Status tray*"))
+ break;
+ }
EXPECT_TRUE(base::MatchPattern(speech_monitor_.GetNextUtterance(), "time *"));
EXPECT_TRUE(base::MatchPattern(speech_monitor_.GetNextUtterance(),
"Battery is*full.,"));
@@ -430,24 +435,38 @@ IN_PROC_BROWSER_TEST_P(SpokenFeedbackTest, NavigateSystemTray) {
EXPECT_TRUE(PerformAcceleratorAction(ash::SHOW_SYSTEM_TRAY_BUBBLE));
while (true) {
std::string utterance = speech_monitor_.GetNextUtterance();
+ if (base::MatchPattern(utterance, "Status tray,"))
+ break;
+ }
+ while (true) {
+ std::string utterance = speech_monitor_.GetNextUtterance();
if (base::MatchPattern(utterance, "window"))
break;
}
SendKeyPress(ui::VKEY_TAB);
- EXPECT_TRUE(base::MatchPattern(speech_monitor_.GetNextUtterance(), "*"));
- EXPECT_TRUE(base::MatchPattern(speech_monitor_.GetNextUtterance(), "Button"));
+ while (true) {
+ std::string utterance = speech_monitor_.GetNextUtterance();
+ if (base::MatchPattern(utterance, "Button"))
+ break;
+ }
// Compat next element.
SendKeyPressWithSearchAndShift(ui::VKEY_RIGHT);
- EXPECT_TRUE(base::MatchPattern(speech_monitor_.GetNextUtterance(), "*"));
- EXPECT_TRUE(base::MatchPattern(speech_monitor_.GetNextUtterance(), "Button"));
+ while (true) {
+ std::string utterance = speech_monitor_.GetNextUtterance();
+ if (base::MatchPattern(utterance, "Button"))
+ break;
+ }
// Compat next button.
SendKeyPressWithSearchAndShift(ui::VKEY_N);
SendKeyPress(ui::VKEY_B);
- EXPECT_TRUE(base::MatchPattern(speech_monitor_.GetNextUtterance(), "*"));
- EXPECT_TRUE(base::MatchPattern(speech_monitor_.GetNextUtterance(), "Button"));
+ while (true) {
+ std::string utterance = speech_monitor_.GetNextUtterance();
+ if (base::MatchPattern(utterance, "Button"))
+ break;
+ }
// Navigate to Bluetooth sub-menu and open it.
while (true) {
@@ -508,15 +527,22 @@ IN_PROC_BROWSER_TEST_P(SpokenFeedbackTest, OverviewMode) {
EnableChromeVox();
EXPECT_TRUE(PerformAcceleratorAction(ash::TOGGLE_OVERVIEW));
- EXPECT_EQ("Edit text", speech_monitor_.GetNextUtterance());
- EXPECT_EQ(", window", speech_monitor_.GetNextUtterance());
+ while (true) {
+ std::string utterance = speech_monitor_.GetNextUtterance();
+ if (base::MatchPattern(utterance, "Edit text"))
+ break;
+ }
EXPECT_EQ("Alert", speech_monitor_.GetNextUtterance());
EXPECT_EQ("Entered window overview mode", speech_monitor_.GetNextUtterance());
SendKeyPress(ui::VKEY_TAB);
// On Chrome OS accessibility title for tabbed browser windows contains app
// name ("Chrome" or "Chromium") in overview mode.
- EXPECT_EQ("Chromium - about:blank", speech_monitor_.GetNextUtterance());
+ while (true) {
+ std::string utterance = speech_monitor_.GetNextUtterance();
+ if (base::MatchPattern(utterance, "Chromium - about:blank"))
+ break;
+ }
EXPECT_EQ("Button", speech_monitor_.GetNextUtterance());
}
« no previous file with comments | « no previous file | ui/views/accessibility/ax_aura_obj_cache.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698