Remove unsafe getFontMetrics methods

third_party/WebKit/Source/platform/fonts/Font.h

Index: third_party/WebKit/Source/platform/fonts/Font.h
diff --git a/third_party/WebKit/Source/platform/fonts/Font.h b/third_party/WebKit/Source/platform/fonts/Font.h
index bff7ab2b0ded9a9ba7b53770ea2e1d11a38d1433..77b837aedae3d6bac52311252578e8181791d891 100644
--- a/third_party/WebKit/Source/platform/fonts/Font.h
+++ b/third_party/WebKit/Source/platform/fonts/Font.h
@@ -123,10 +123,6 @@ class PLATFORM_EXPORT Font {
   Vector<CharacterRange> individualCharacterRanges(const TextRun&) const;
 
   // Metrics that we query the FontFallbackList for.
-  const FontMetrics& getFontMetrics() const {

[wkorman, 2016/10/13 22:54:31]

Suggest adding documentation to Font::primaryFont() method to explain generally
why we can end up with no primary font. Naively it's not clear how this would
happen, and whether there's a layer of logic elsewhere that makes sure we fall
back to some super-general default, or if instead all logic has to make sure to
essentially deal with a situation where there is no font and so no text can
pragmatically be laid out/painted.

[eae, 2016/10/13 23:09:58]

Done, thank you.

-    RELEASE_ASSERT(primaryFont());
-    return primaryFont()->getFontMetrics();
-  }
   float spaceWidth() const {
     return primaryFont()->spaceWidth() + getFontDescription().letterSpacing();
   }