Remove unsafe getFontMetrics methods

third_party/WebKit/Source/platform/fonts/Font.h

 /*
  * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
  *           (C) 2000 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2003, 2006, 2007, 2010, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Holger Hans Peter Freyther
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 105 matching lines @@
                                  int h,
                                  int from = 0,
                                  int to = -1,
                                  bool accountForGlyphBounds = false) const;
   CharacterRange getCharacterRange(const TextRun&,
                                    unsigned from,
                                    unsigned to) const;
   Vector<CharacterRange> individualCharacterRanges(const TextRun&) const;
 
   // Metrics that we query the FontFallbackList for.
-  const FontMetrics& getFontMetrics() const {

[wkorman, 2016/10/13 22:54:31]

Suggest adding documentation to Font::primaryFont() method to explain generally
why we can end up with no primary font. Naively it's not clear how this would
happen, and whether there's a layer of logic elsewhere that makes sure we fall
back to some super-general default, or if instead all logic has to make sure to
essentially deal with a situation where there is no font and so no text can
pragmatically be laid out/painted.

[eae, 2016/10/13 23:09:58]

Done, thank you.

-    RELEASE_ASSERT(primaryFont());
-    return primaryFont()->getFontMetrics();
-  }
   float spaceWidth() const {
     return primaryFont()->spaceWidth() + getFontDescription().letterSpacing();
   }
   float tabWidth(const SimpleFontData&, const TabSize&, float position) const;
   float tabWidth(const TabSize& tabSize, float position) const {
     return tabWidth(*primaryFont(), tabSize, position);
   }
 
   int emphasisMarkAscent(const AtomicString&) const;
   int emphasisMarkDescent(const AtomicString&) const;
@@ skipping 117 matching lines @@
   // advance an additional tab stop.
   if (distanceToTabStop < fontData.spaceWidth() / 2)
     distanceToTabStop += baseTabWidth;
 
   return distanceToTabStop;
 }
 
 }  // namespace blink
 
 #endif