Issue 241603002: Revert of Fix memory leak in SkGradientShader.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 241603002: Revert of Fix memory leak in SkGradientShader. (Closed)

Created:
6 years, 8 months ago by bungeman-skia

Modified:
6 years, 8 months ago

Reviewers:
Dominik Grewe, scroggo, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

Revert of Fix memory leak in SkGradientShader. (https://codereview.chromium.org/240303003/) Reason for revert: This and https://codereview.chromium.org/207683004 are causing memory leaks. Original issue's description: > Fix memory leak in SkGradientShader. > > Make sure pointer to gradient shader cache is unreffed in SkGradientShaderBase::getGradientTableBitmap. > Rename methods returning a "pre-reffed" object to indicate obligations. > > BUG=skia:1976 > > Committed: http://code.google.com/p/skia/source/detail?r=14223 TBR=reed@google.com,scroggo@google.com,dominikg@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia:1976 Committed: http://code.google.com/p/skia/source/detail?r=14245

Created: 6 years, 8 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -15 lines)			Patch
M	src/core/SkPictureShader.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/core/SkPictureShader.cpp	View	4 chunks	+15 lines, -10 lines	0 comments	Download
M	src/effects/gradients/SkGradientShader.cpp	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/effects/gradients/SkGradientShaderPriv.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

bungeman-skia

Created Revert of Fix memory leak in SkGradientShader.

6 years, 8 months ago (2014-04-17 21:01:27 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bungeman@google.com/241603002/1

6 years, 8 months ago (2014-04-17 21:02:15 UTC) #2

Message was sent while issue was closed.

Change committed as 14245