Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 2415993003: Remove RETURN_RESULT macro (Closed)

Created:
4 years, 2 months ago by jgruber
Modified:
4 years, 2 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove RETURN_RESULT macro 'RETURN_RESULT(isolate, call, type)' is equivalent to 'return call' in all current use cases. BUG= Committed: https://crrev.com/6f7cbc23c070005967f2e829d11877925fd3bc70 Cr-Commit-Position: refs/heads/master@{#40302}

Patch Set 1 #

Patch Set 2 : Remove RETURN_RESULT macro #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -17 lines) Patch
M src/builtins/builtins-regexp.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/isolate.h View 1 1 chunk +0 lines, -10 lines 0 comments Download
M src/messages.cc View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
jgruber
4 years, 2 months ago (2016-10-14 08:40:05 UTC) #6
Yang
On 2016/10/14 08:40:05, jgruber wrote: lgtm.
4 years, 2 months ago (2016-10-14 08:42:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2415993003/20001
4 years, 2 months ago (2016-10-14 09:14:21 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-14 09:18:43 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 09:19:02 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6f7cbc23c070005967f2e829d11877925fd3bc70
Cr-Commit-Position: refs/heads/master@{#40302}

Powered by Google App Engine
This is Rietveld 408576698