Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1184)

Unified Diff: src/messages.cc

Issue 2415993003: Remove RETURN_RESULT macro (Closed)
Patch Set: Remove RETURN_RESULT macro Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/isolate.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/messages.cc
diff --git a/src/messages.cc b/src/messages.cc
index 59c33abcd5d5e0d99e939f186e29ee4ea42ed975..8cf478e6f3889965301f371490d023214c944b03 100644
--- a/src/messages.cc
+++ b/src/messages.cc
@@ -598,14 +598,14 @@ MaybeHandle<String> JSStackFrame::ToString() {
builder.AppendString(Handle<String>::cast(function_name));
} else {
AppendFileLocation(isolate_, this, &builder);
- RETURN_RESULT(isolate_, builder.Finish(), String);
+ return builder.Finish();
}
builder.AppendCString(" (");
AppendFileLocation(isolate_, this, &builder);
builder.AppendCString(")");
- RETURN_RESULT(isolate_, builder.Finish(), String);
+ return builder.Finish();
}
int JSStackFrame::GetPosition() const { return code_->SourcePosition(offset_); }
@@ -734,7 +734,7 @@ MaybeHandle<String> AsmJsWasmStackFrame::ToString() {
if (IsNonEmptyString(function_name)) builder.AppendCString(")");
- RETURN_RESULT(isolate_, builder.Finish(), String);
+ return builder.Finish();
}
FrameArrayIterator::FrameArrayIterator(Isolate* isolate,
@@ -943,7 +943,7 @@ MaybeHandle<Object> ErrorUtils::FormatStackTrace(Isolate* isolate,
}
}
- RETURN_RESULT(isolate, builder.Finish(), Object);
+ return builder.Finish();
}
Handle<String> MessageTemplate::FormatMessage(Isolate* isolate,
« no previous file with comments | « src/isolate.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698