Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 2415933003: DevTools: explicitly reveal the stack frame location upon click. (Closed)

Created:
4 years, 2 months ago by pfeldman
Modified:
4 years, 2 months ago
Reviewers:
kozy, alph
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: explicitly reveal the stack frame location upon click. BUG=650300 Committed: https://crrev.com/51197335cbfe3384b6bdb5ad7de923a7ba0acb74 Cr-Commit-Position: refs/heads/master@{#425381}

Patch Set 1 #

Patch Set 2 : removed the check #

Total comments: 1

Patch Set 3 : review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js View 1 2 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
pfeldman
4 years, 2 months ago (2016-10-13 20:17:24 UTC) #2
alph
lgtm
4 years, 2 months ago (2016-10-13 21:06:41 UTC) #4
kozy
lgtm https://codereview.chromium.org/2415933003/diff/20001/third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js File third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js (right): https://codereview.chromium.org/2415933003/diff/20001/third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js#newcode418 third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js:418: var uiLocation = WebInspector.debuggerWorkspaceBinding.rawLocationToUILocation(callFrame.location()); Can we reveal location ...
4 years, 2 months ago (2016-10-13 22:56:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2415933003/40001
4 years, 2 months ago (2016-10-13 22:59:28 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/314376)
4 years, 2 months ago (2016-10-14 00:13:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2415933003/40001
4 years, 2 months ago (2016-10-14 16:51:56 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-14 17:44:36 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 17:47:39 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/51197335cbfe3384b6bdb5ad7de923a7ba0acb74
Cr-Commit-Position: refs/heads/master@{#425381}

Powered by Google App Engine
This is Rietveld 408576698