Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js

Issue 2415933003: DevTools: explicitly reveal the stack frame location upon click. (Closed)
Patch Set: review comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js b/third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js
index 3b6b525f7e1b1c0a406c92c5cf409a005432ece1..fae4ed574e2987136feeb5bc889f92d9bf164366 100644
--- a/third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js
+++ b/third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js
@@ -413,6 +413,13 @@ WebInspector.CallStackSidebarPane.prototype = {
this._revealHiddenCallFrames();
}
+ var oldCallFrame = WebInspector.context.flavor(WebInspector.DebuggerModel.CallFrame);
+ if (oldCallFrame === callFrame) {
+ var uiLocation = WebInspector.debuggerWorkspaceBinding.rawLocationToUILocation(callFrame.location());
+ WebInspector.Revealer.reveal(uiLocation);
+ return;
+ }
+
WebInspector.context.setFlavor(WebInspector.DebuggerModel.CallFrame, callFrame);
callFrame.debuggerModel.setSelectedCallFrame(callFrame);
},
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698