Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issue 2415923003: Fix setting textContent to empty string (Closed)

Created:
4 years, 2 months ago by rwlbuis
Modified:
4 years, 2 months ago
Reviewers:
foolip
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix setting textContent to empty string Fix setting textContent to empty string, when setting textContent to empty string we are supposed to remove all element text children [1]. Behavior matches Firefox and Safari. BUG=651744 [1] https://dom.spec.whatwg.org/#dom-node-textcontent Committed: https://crrev.com/682e51aaa07cf4e7d1632496d39236b70933ef2d Cr-Commit-Position: refs/heads/master@{#425453}

Patch Set 1 #

Patch Set 2 : Remove test expectations #

Total comments: 2

Patch Set 3 : Remove test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -427 lines) Patch
D third_party/WebKit/LayoutTests/fast/dom/Node/textContent.html View 1 2 1 chunk +0 lines, -258 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Node/textContent-expected.txt View 1 1 chunk +0 lines, -84 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/wpt/dom/nodes/Node-textContent-expected.txt View 1 1 chunk +0 lines, -84 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (9 generated)
rwlbuis
PTAL.
4 years, 2 months ago (2016-10-13 20:08:38 UTC) #4
foolip
LGTM. Edge also passes these subtests. https://codereview.chromium.org/2415923003/diff/20001/third_party/WebKit/LayoutTests/fast/dom/Node/textContent-expected.txt File third_party/WebKit/LayoutTests/fast/dom/Node/textContent-expected.txt (left): https://codereview.chromium.org/2415923003/diff/20001/third_party/WebKit/LayoutTests/fast/dom/Node/textContent-expected.txt#oldcode2 third_party/WebKit/LayoutTests/fast/dom/Node/textContent-expected.txt:2: PASS For an ...
4 years, 2 months ago (2016-10-13 21:17:11 UTC) #5
rwlbuis
https://codereview.chromium.org/2415923003/diff/20001/third_party/WebKit/LayoutTests/fast/dom/Node/textContent-expected.txt File third_party/WebKit/LayoutTests/fast/dom/Node/textContent-expected.txt (left): https://codereview.chromium.org/2415923003/diff/20001/third_party/WebKit/LayoutTests/fast/dom/Node/textContent-expected.txt#oldcode2 third_party/WebKit/LayoutTests/fast/dom/Node/textContent-expected.txt:2: PASS For an empty Element, textContent should be the ...
4 years, 2 months ago (2016-10-14 14:17:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2415923003/40001
4 years, 2 months ago (2016-10-14 14:18:21 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/311833)
4 years, 2 months ago (2016-10-14 18:26:19 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2415923003/40001
4 years, 2 months ago (2016-10-14 19:06:34 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-14 20:37:36 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 20:39:03 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/682e51aaa07cf4e7d1632496d39236b70933ef2d
Cr-Commit-Position: refs/heads/master@{#425453}

Powered by Google App Engine
This is Rietveld 408576698