Fix setting textContent to empty string

Fix setting textContent to empty string

Fix setting textContent to empty string, when setting
textContent to empty string we are supposed to remove
all element text children [1].

Behavior matches Firefox and Safari.

BUG=651744
[1] https://dom.spec.whatwg.org/#dom-node-textcontent

Committed: https://crrev.com/682e51aaa07cf4e7d1632496d39236b70933ef2d
Cr-Commit-Position: refs/heads/master@{#425453}

[rwlbuis, 2016-10-13 15:40:00]

Description was changed from

==========
setTextContent WIP

BUG=
==========

to

==========
setTextContent WIP

BUG=651744
==========

[rwlbuis, 2016-10-13 19:51:36]

Description was changed from

==========
setTextContent WIP

BUG=651744
==========

to

==========
Fix setting textContent to empty string

Fix setting textContent to empty string, when setting 
textContent to empty string we are supposed to remove
all element text children [1].

Behavior matches Firefox and Safari.

BUG=651744

[1] https://dom.spec.whatwg.org/#dom-node-textcontent
==========

[rwlbuis, 2016-10-13 20:08:37]

rob.buis@samsung.com changed reviewers:
+ foolip@chromium.org

[rwlbuis, 2016-10-13 20:08:38]

PTAL.

[foolip, 2016-10-13 21:17:11]

LGTM. Edge also passes these subtests.

https://codereview.chromium.org/2415923003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/dom/Node/textContent-expected.txt
(left):

https://codereview.chromium.org/2415923003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/dom/Node/textContent-expected.txt:2: PASS
For an empty Element, textContent should be the empty string
Looks like this is a copied test, can you check if it has diverged and if not
delete it?

[rwlbuis, 2016-10-14 14:17:55]

https://codereview.chromium.org/2415923003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/dom/Node/textContent-expected.txt
(left):

https://codereview.chromium.org/2415923003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/dom/Node/textContent-expected.txt:2: PASS
For an empty Element, textContent should be the empty string
On 2016/10/13 21:17:11, foolip wrote:
> Looks like this is a copied test, can you check if it has diverged and if not
> delete it?

Correct, it is same as imported test but older version, will remove.

[rwlbuis, 2016-10-14 14:18:15]

The CQ bit was checked by rob.buis@samsung.com

[rwlbuis, 2016-10-14 14:18:16]

The patchset sent to the CQ was uploaded after l-g-t-m from foolip@chromium.org
Link to the patchset: https://codereview.chromium.org/2415923003/#ps40001
(title: "Remove test")

[commit-bot: I haz the power, 2016-10-14 14:18:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 18:26:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 18:26:19]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[rwlbuis, 2016-10-14 19:06:01]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2016-10-14 19:06:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 20:37:34]

Description was changed from

==========
Fix setting textContent to empty string

Fix setting textContent to empty string, when setting 
textContent to empty string we are supposed to remove
all element text children [1].

Behavior matches Firefox and Safari.

BUG=651744

[1] https://dom.spec.whatwg.org/#dom-node-textcontent
==========

to

==========
Fix setting textContent to empty string

Fix setting textContent to empty string, when setting 
textContent to empty string we are supposed to remove
all element text children [1].

Behavior matches Firefox and Safari.

BUG=651744

[1] https://dom.spec.whatwg.org/#dom-node-textcontent
==========

[commit-bot: I haz the power, 2016-10-14 20:37:36]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-14 20:39:02]

Description was changed from

==========
Fix setting textContent to empty string

Fix setting textContent to empty string, when setting 
textContent to empty string we are supposed to remove
all element text children [1].

Behavior matches Firefox and Safari.

BUG=651744

[1] https://dom.spec.whatwg.org/#dom-node-textcontent
==========

to

==========
Fix setting textContent to empty string

Fix setting textContent to empty string, when setting
textContent to empty string we are supposed to remove
all element text children [1].

Behavior matches Firefox and Safari.

BUG=651744

[1] https://dom.spec.whatwg.org/#dom-node-textcontent

Committed: https://crrev.com/682e51aaa07cf4e7d1632496d39236b70933ef2d
Cr-Commit-Position: refs/heads/master@{#425453}
==========

[commit-bot: I haz the power, 2016-10-14 20:39:03]

Patchset 3 (id:??) landed as
https://crrev.com/682e51aaa07cf4e7d1632496d39236b70933ef2d
Cr-Commit-Position: refs/heads/master@{#425453}