Use PermissionType instead of ContentSettingsType in Android permission infobars

Use PermissionType instead of ContentSettingsType in Android permission infobars

Content settings layer is more about storage below the permission layer, so we 
should use PermissionType instead of ContentSettingsType in Android permission 
infobars.

This CL migrated PermissionInfoBar and GroupedPermissionInfoBar to use
permission types. This also has benefits of removing the content_settings_type_ 
member variable in PermissionInfoBarDelegate, which currently is using both
content_settings_type_ and permission_type_ in all subclasses.

BUG=458606

[lshang, 2016-10-13 02:19:21]

The CQ bit was checked by lshang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 02:19:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lshang, 2016-10-13 02:50:28]

Description was changed from

==========
Use PermissionType instead of ContentSettingsType in Android permission infobars

BUG=
==========

to

==========
Use PermissionType instead of ContentSettingsType in Android permission infobars

Content settings layer is more about storage below the permission layer, so we 
should use PermissionType instead of ContentSettingsType in Android permission 
infobars.

This CL migrated PermissionInfoBar and GroupedPermissionInfoBar to use
permission types. This also has benefits of removing the content_settings_type_ 
member variable in PermissionInfoBarDelegate, which currently is using both
content_settings_type_ and permission_type_ in all subclasses.

BUG=458606
==========

[lshang, 2016-10-13 02:53:08]

lshang@chromium.org changed reviewers:
+ raymes@chromium.org

[lshang, 2016-10-13 02:53:09]

raymes@: PTAL thanks! This CL changes to use PermissionType instead of
ContentSettingsType in permission infobars, so that we can remove the
PermissionType->ContentSettingsType conversion in PermissionRequest in the other
CL.

[commit-bot: I haz the power, 2016-10-13 03:13:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 03:13:14]

Dry run: This issue passed the CQ dry run.

[lshang, 2016-10-15 05:36:18]

The CQ bit was checked by lshang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-15 05:36:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lshang, 2016-10-15 07:02:48]

The CQ bit was checked by lshang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-15 07:02:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lshang, 2016-10-15 07:03:11]

Patchset #2 (id:20001) has been deleted

[lshang, 2016-10-15 07:03:24]

Patchset #2 (id:40001) has been deleted

[commit-bot: I haz the power, 2016-10-15 07:57:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-15 07:57:03]

Dry run: This issue passed the CQ dry run.

[raymes, 2016-10-17 01:11:12]

lgtm

https://codereview.chromium.org/2415863002/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/GroupedPermissionInfoBar.java
(right):

https://codereview.chromium.org/2415863002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/infobar/GroupedPermissionInfoBar.java:23:
private final int[] mPermissions;
nit: mPermissionTypes (here and below)

https://codereview.chromium.org/2415863002/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/PermissionInfoBar.java
(right):

https://codereview.chromium.org/2415863002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/infobar/PermissionInfoBar.java:75:
* @param permissions The list of {@link PermissionType}s whose access is guarded
nit: permissionTypes

https://codereview.chromium.org/2415863002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/infobar/PermissionInfoBar.java:224:
* @param permissions The list of PermissionTypes being requested by this
infobar.
nit: permissionTypes

https://codereview.chromium.org/2415863002/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java
(right):

https://codereview.chromium.org/2415863002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java:251:
public static String getAndroidPermissionForContentSetting(int
contentSettingType) {
Hmm it would be good to remove this asap. Besides the duplicated code, we don't
have any type checking and I would be worried that people would use the wrong
one and get the wrong result. Could you please file a bug and note it in the
comment? 

We can also get thoughts from the android OWNERS. Ideally I'd just like to
remove ContentSettingsType from the code altogether.

https://codereview.chromium.org/2415863002/diff/60001/chrome/browser/ui/andro...
File chrome/browser/ui/android/infobars/permission_infobar.cc (right):

https://codereview.chromium.org/2415863002/diff/60001/chrome/browser/ui/andro...
chrome/browser/ui/android/infobars/permission_infobar.cc:58: std::vector<int>
permissions{delegate->permission_types()};
nit: permission_types

[raymes, 2016-10-17 02:11:24]

As discussed, let's not land this for now and go with the other solution.