Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Side by Side Diff: chrome/browser/ui/android/infobars/grouped_permission_infobar.cc

Issue 2415863002: Use PermissionType instead of ContentSettingsType in Android permission infobars (Closed)
Patch Set: Merge branch 'master' into use_permission_type_for_infobar Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/android/infobars/grouped_permission_infobar.h" 5 #include "chrome/browser/ui/android/infobars/grouped_permission_infobar.h"
6 6
7 #include "base/android/jni_android.h" 7 #include "base/android/jni_android.h"
8 #include "base/android/jni_array.h" 8 #include "base/android/jni_array.h"
9 #include "base/android/jni_string.h" 9 #include "base/android/jni_string.h"
10 #include "chrome/browser/android/resource_mapper.h" 10 #include "chrome/browser/android/resource_mapper.h"
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 env, delegate->GetMessageText()); 54 env, delegate->GetMessageText());
55 base::android::ScopedJavaLocalRef<jstring> ok_button_text = 55 base::android::ScopedJavaLocalRef<jstring> ok_button_text =
56 base::android::ConvertUTF16ToJavaString( 56 base::android::ConvertUTF16ToJavaString(
57 env, GetTextFor(ConfirmInfoBarDelegate::BUTTON_OK)); 57 env, GetTextFor(ConfirmInfoBarDelegate::BUTTON_OK));
58 base::android::ScopedJavaLocalRef<jstring> cancel_button_text = 58 base::android::ScopedJavaLocalRef<jstring> cancel_button_text =
59 base::android::ConvertUTF16ToJavaString( 59 base::android::ConvertUTF16ToJavaString(
60 env, GetTextFor(ConfirmInfoBarDelegate::BUTTON_CANCEL)); 60 env, GetTextFor(ConfirmInfoBarDelegate::BUTTON_CANCEL));
61 61
62 std::vector<base::string16> permission_strings; 62 std::vector<base::string16> permission_strings;
63 std::vector<int> permission_icons; 63 std::vector<int> permission_icons;
64 std::vector<int> content_settings_types; 64 std::vector<int> permission_types;
65 65
66 for (size_t i = 0; i < delegate->permission_count(); i++) { 66 for (size_t i = 0; i < delegate->permission_count(); i++) {
67 permission_strings.push_back(delegate->GetMessageTextFragment(i)); 67 permission_strings.push_back(delegate->GetMessageTextFragment(i));
68 permission_icons.push_back( 68 permission_icons.push_back(
69 ResourceMapper::MapFromChromiumId(delegate->GetIconIdForPermission(i))); 69 ResourceMapper::MapFromChromiumId(delegate->GetIconIdForPermission(i)));
70 content_settings_types.push_back(delegate->GetContentSettingType(i)); 70 permission_types.push_back(
71 static_cast<int>(delegate->GetPermissionType(i)));
71 } 72 }
72 73
73 return Java_GroupedPermissionInfoBar_create( 74 return Java_GroupedPermissionInfoBar_create(
74 env, message_text, ok_button_text, cancel_button_text, 75 env, message_text, ok_button_text, cancel_button_text,
75 base::android::ToJavaIntArray(env, permission_icons), 76 base::android::ToJavaIntArray(env, permission_icons),
76 base::android::ToJavaArrayOfStrings(env, permission_strings), 77 base::android::ToJavaArrayOfStrings(env, permission_strings),
77 GetWindowAndroid(), 78 GetWindowAndroid(), base::android::ToJavaIntArray(env, permission_types),
78 base::android::ToJavaIntArray(env, content_settings_types),
79 delegate->ShouldShowPersistenceToggle()); 79 delegate->ShouldShowPersistenceToggle());
80 } 80 }
81 81
82 void GroupedPermissionInfoBar::SetJavaInfoBar( 82 void GroupedPermissionInfoBar::SetJavaInfoBar(
83 const base::android::JavaRef<jobject>& java_info_bar) { 83 const base::android::JavaRef<jobject>& java_info_bar) {
84 InfoBarAndroid::SetJavaInfoBar(java_info_bar); 84 InfoBarAndroid::SetJavaInfoBar(java_info_bar);
85 JNIEnv* env = base::android::AttachCurrentThread(); 85 JNIEnv* env = base::android::AttachCurrentThread();
86 Java_GroupedPermissionInfoBar_setNativePtr(env, java_info_bar, 86 Java_GroupedPermissionInfoBar_setNativePtr(env, java_info_bar,
87 reinterpret_cast<intptr_t>(this)); 87 reinterpret_cast<intptr_t>(this));
88 } 88 }
89 89
90 GroupedPermissionInfoBarDelegate* GroupedPermissionInfoBar::GetDelegate() { 90 GroupedPermissionInfoBarDelegate* GroupedPermissionInfoBar::GetDelegate() {
91 return static_cast<GroupedPermissionInfoBarDelegate*>(delegate()); 91 return static_cast<GroupedPermissionInfoBarDelegate*>(delegate());
92 } 92 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698