Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2415673005: Revert of Move GetProgramCounter in FROM_HERE to a common function (Closed)

Created:
4 years, 2 months ago by henrika (OOO until Aug 14)
Modified:
4 years, 2 months ago
Reviewers:
dcheng, tzik
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move GetProgramCounter in FROM_HERE to a common function (patchset #6 id:100001 of https://codereview.chromium.org/2399053004/ ) Reason for revert: Breaks LocationTest.TestProgramCounter on Windows. https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/53641/steps/base_unittests%20on%20Windows-7-SP1/logs/LocationTest.TestProgramCounter Original issue's description: > Move GetProgramCounter in FROM_HERE to a common function > > tracked_objects::GetProgramCounter() is called for each FROM_HERE macro, > and each of the function call costs 8 bytes. > This CL adds a static constructor, Location::CreateForCurrentProgramCounter, > that calculates the program counter by itself for smaller number of GPC > call. > > This reduces the stripped binary size of chrome on Linux by 56kB. > > BUG=645364 > > Committed: https://crrev.com/004d27129e4f66004775759736d9ab5152a3ecbf > Cr-Commit-Position: refs/heads/master@{#425289} TBR=dcheng@chromium.org,tzik@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=645364 Committed: https://crrev.com/454c124bcbcfdf9fd556639c80e7a11dc19e04ec Cr-Commit-Position: refs/heads/master@{#425298}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -65 lines) Patch
M base/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M base/location.h View 2 chunks +5 lines, -8 lines 0 comments Download
M base/location.cc View 3 chunks +7 lines, -32 lines 0 comments Download
D base/location_unittest.cc View 1 chunk +0 lines, -24 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
henrika (OOO until Aug 14)
Created Revert of Move GetProgramCounter in FROM_HERE to a common function
4 years, 2 months ago (2016-10-14 12:09:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2415673005/1
4 years, 2 months ago (2016-10-14 12:10:04 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-14 12:11:08 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 12:13:17 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/454c124bcbcfdf9fd556639c80e7a11dc19e04ec
Cr-Commit-Position: refs/heads/master@{#425298}

Powered by Google App Engine
This is Rietveld 408576698