DescriptionRevert of Move GetProgramCounter in FROM_HERE to a common function (patchset #6 id:100001 of https://codereview.chromium.org/2399053004/ )
Reason for revert:
Breaks LocationTest.TestProgramCounter on Windows.
https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/53641/steps/base_unittests%20on%20Windows-7-SP1/logs/LocationTest.TestProgramCounter
Original issue's description:
> Move GetProgramCounter in FROM_HERE to a common function
>
> tracked_objects::GetProgramCounter() is called for each FROM_HERE macro,
> and each of the function call costs 8 bytes.
> This CL adds a static constructor, Location::CreateForCurrentProgramCounter,
> that calculates the program counter by itself for smaller number of GPC
> call.
>
> This reduces the stripped binary size of chrome on Linux by 56kB.
>
> BUG=645364
>
> Committed: https://crrev.com/004d27129e4f66004775759736d9ab5152a3ecbf
> Cr-Commit-Position: refs/heads/master@{#425289}
TBR=dcheng@chromium.org,tzik@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=645364
Committed: https://crrev.com/454c124bcbcfdf9fd556639c80e7a11dc19e04ec
Cr-Commit-Position: refs/heads/master@{#425298}
Patch Set 1 #
Messages
Total messages: 7 (3 generated)
|