Move GetProgramCounter in FROM_HERE to a common function

Move GetProgramCounter in FROM_HERE to a common function

tracked_objects::GetProgramCounter() is called for each FROM_HERE macro,
and each of the function call costs 8 bytes.
This CL adds a static constructor, Location::CreateForCurrentProgramCounter,
that calculates the program counter by itself for smaller number of GPC
call.

This reduces the stripped binary size of chrome on Linux by 56kB.

BUG=645364
Committed: https://crrev.com/004d27129e4f66004775759736d9ab5152a3ecbf
Cr-Commit-Position: refs/heads/master@{#425289}

[tzik, 2016-10-07 17:49:59]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-07 17:50:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2016-10-07 18:07:06]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-07 18:07:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2016-10-07 18:15:23]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-07 18:15:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2016-10-07 18:20:28]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-07 18:20:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2016-10-07 18:33:20]

tzik@chromium.org changed reviewers:
+ dcheng@chromium.org

[tzik, 2016-10-07 18:33:21]

PTAL

[commit-bot: I haz the power, 2016-10-07 18:38:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 18:38:34]

Dry run: Try jobs failed on following builders:
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[dcheng, 2016-10-07 21:16:26]

I wonder: would it be possible to integrate this directly into the Location
constructor?

[tzik, 2016-10-08 04:52:50]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-08 04:53:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-08 06:50:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-08 06:50:15]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[tzik, 2016-10-08 07:41:12]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-08 07:41:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-08 09:23:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-08 09:23:31]

Dry run: This issue passed the CQ dry run.

[tzik, 2016-10-08 12:32:05]

On 2016/10/07 21:16:26, dcheng wrote:
> I wonder: would it be possible to integrate this directly into the Location
> constructor?

That's possible, but I feel it's a bit error prone since the constructor can be
called from other constructors and subclasses.

[tzik, 2016-10-08 21:41:07]

Description was changed from

==========
Move GetProgramCounter in FROM_HERE to a common function

tracked_objects::GetProgramCounter() is called for each FROM_HERE macro,
and each of the function call costs 8 bytes.
This CL adds a static constructor, Location::CreateForCurrentProgramCounter,
that calculates the program counter by itself for smaller number of GPC
call.

This reduces the stripped binary size of chrome on Linux by 56kB.

BUG=
==========

to

==========
Move GetProgramCounter in FROM_HERE to a common function

tracked_objects::GetProgramCounter() is called for each FROM_HERE macro,
and each of the function call costs 8 bytes.
This CL adds a static constructor, Location::CreateForCurrentProgramCounter,
that calculates the program counter by itself for smaller number of GPC
call.

This reduces the stripped binary size of chrome on Linux by 56kB.

BUG=645364
==========

[tzik, 2016-10-14 07:48:18]

On 2016/10/08 12:32:05, tzik wrote:
> On 2016/10/07 21:16:26, dcheng wrote:
> > I wonder: would it be possible to integrate this directly into the Location
> > constructor?
> 
> That's possible, but I feel it's a bit error prone since the constructor can
be
> called from other constructors and subclasses.

ping.
Any opinion on this?

[dcheng, 2016-10-14 07:56:34]

lgtm

[tzik, 2016-10-14 08:52:10]

The CQ bit was checked by tzik@chromium.org

[commit-bot: I haz the power, 2016-10-14 08:52:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 10:29:17]

Description was changed from

==========
Move GetProgramCounter in FROM_HERE to a common function

tracked_objects::GetProgramCounter() is called for each FROM_HERE macro,
and each of the function call costs 8 bytes.
This CL adds a static constructor, Location::CreateForCurrentProgramCounter,
that calculates the program counter by itself for smaller number of GPC
call.

This reduces the stripped binary size of chrome on Linux by 56kB.

BUG=645364
==========

to

==========
Move GetProgramCounter in FROM_HERE to a common function

tracked_objects::GetProgramCounter() is called for each FROM_HERE macro,
and each of the function call costs 8 bytes.
This CL adds a static constructor, Location::CreateForCurrentProgramCounter,
that calculates the program counter by itself for smaller number of GPC
call.

This reduces the stripped binary size of chrome on Linux by 56kB.

BUG=645364
==========

[commit-bot: I haz the power, 2016-10-14 10:29:18]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-10-14 10:30:48]

Description was changed from

==========
Move GetProgramCounter in FROM_HERE to a common function

tracked_objects::GetProgramCounter() is called for each FROM_HERE macro,
and each of the function call costs 8 bytes.
This CL adds a static constructor, Location::CreateForCurrentProgramCounter,
that calculates the program counter by itself for smaller number of GPC
call.

This reduces the stripped binary size of chrome on Linux by 56kB.

BUG=645364
==========

to

==========
Move GetProgramCounter in FROM_HERE to a common function

tracked_objects::GetProgramCounter() is called for each FROM_HERE macro,
and each of the function call costs 8 bytes.
This CL adds a static constructor, Location::CreateForCurrentProgramCounter,
that calculates the program counter by itself for smaller number of GPC
call.

This reduces the stripped binary size of chrome on Linux by 56kB.

BUG=645364

Committed: https://crrev.com/004d27129e4f66004775759736d9ab5152a3ecbf
Cr-Commit-Position: refs/heads/master@{#425289}
==========

[commit-bot: I haz the power, 2016-10-14 10:30:49]

Patchset 6 (id:??) landed as
https://crrev.com/004d27129e4f66004775759736d9ab5152a3ecbf
Cr-Commit-Position: refs/heads/master@{#425289}

[henrika (OOO until Aug 14), 2016-10-14 12:09:49]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/2415673005/ by henrika@chromium.org.

The reason for reverting is: Breaks LocationTest.TestProgramCounter on Windows.

https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%....