Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 2415573002: customtabs: Add paranoia to isCallerForegroundOrSelf() due to NPEs in the wild. (Closed)

Created:
4 years, 2 months ago by Benoit L
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

customtabs: Add paranoia to isCallerForegroundOrSelf() due to NPEs in the wild. We have a number of NPEs reported from devices in the wild. Unfortunately, we only know that they happen on L pre-MR1, and from warmup(). This commits adds null checks to prevent these from crashing the client (reported by GSA). BUG=654705 Review-Url: https://codereview.chromium.org/2404183004 Cr-Commit-Position: refs/heads/master@{#424406} (cherry picked from commit f974fe4e5a32803b83592a014a82db683cb485f7) Committed: https://chromium.googlesource.com/chromium/src/+/1d5357e02cda8ed82b7788b76e036937a329460f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -10 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java View 1 chunk +18 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Benoit L
4 years, 2 months ago (2016-10-12 14:09:26 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1d5357e02cda8ed82b7788b76e036937a329460f.

Powered by Google App Engine
This is Rietveld 408576698