Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 2404183004: customtabs: Add paranoia to isCallerForegroundOrSelf() due to NPEs in the wild. (Closed)

Created:
4 years, 2 months ago by Benoit L
Modified:
4 years, 2 months ago
Reviewers:
pasko
CC:
chromium-reviews, lizeb+watch-custom-tabs_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

customtabs: Add paranoia to isCallerForegroundOrSelf() due to NPEs in the wild. We have a number of NPEs reported from devices in the wild. Unfortunately, we only know that they happen on L pre-MR1, and from warmup(). This commits adds null checks to prevent these from crashing the client (reported by GSA). BUG=654705 Committed: https://crrev.com/f974fe4e5a32803b83592a014a82db683cb485f7 Cr-Commit-Position: refs/heads/master@{#424406}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -10 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java View 1 chunk +18 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Benoit L
4 years, 2 months ago (2016-10-11 10:56:43 UTC) #2
pasko
lgtm
4 years, 2 months ago (2016-10-11 11:20:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2404183004/1
4 years, 2 months ago (2016-10-11 11:51:57 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 11:56:56 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 11:58:40 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f974fe4e5a32803b83592a014a82db683cb485f7
Cr-Commit-Position: refs/heads/master@{#424406}

Powered by Google App Engine
This is Rietveld 408576698