[Blink, RemotePlayback]Split onstatechange to separate events

[Blink, RemotePlayback]Split onstatechange to separate events

BUG=655340
TEST=Unit test + http://avayvod.github.io/remote-playback/test.html

Committed: https://crrev.com/7291ab8a6a4cef9b5eda1e04bd5f2578b86ad17f
Cr-Commit-Position: refs/heads/master@{#425057}

[whywhat, 2016-10-12 22:18:05]

The CQ bit was checked by avayvod@chromium.org to run a CQ dry run

[whywhat, 2016-10-12 22:18:13]

avayvod@chromium.org changed reviewers:
+ mlamouri@chromium.org

[whywhat, 2016-10-12 22:18:14]

PTaL

[commit-bot: I haz the power, 2016-10-12 22:18:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 23:27:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 23:27:56]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[whywhat, 2016-10-13 01:20:40]

Fixed global-interface-listing test

[whywhat, 2016-10-13 01:24:10]

The CQ bit was checked by avayvod@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 01:24:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[whywhat, 2016-10-13 01:55:17]

Description was changed from

==========
[Blink, RemotePlayback]Split onstatechange to separate events

BUG=655340
TEST=Unit test.
==========

to

==========
[Blink, RemotePlayback]Split onstatechange to separate events

BUG=655340
TEST=Unit test + http://avayvod.github.io/remote-playback/test.html
==========

[commit-bot: I haz the power, 2016-10-13 02:50:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 02:50:20]

Dry run: This issue passed the CQ dry run.

[mlamouri (slow - plz ping), 2016-10-13 14:37:45]

lgtm with one comment

https://codereview.chromium.org/2415443004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/remoteplayback/RemotePlaybackTest.cpp
(right):

https://codereview.chromium.org/2415443004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/remoteplayback/RemotePlaybackTest.cpp:102:
setState(remotePlayback, WebRemotePlaybackState::Disconnected);
Can you add double-calls? Like:

  setState(remotePlayback, WebRemotePlaybackState::Connecting);
  setState(remotePlayback, WebRemotePlaybackState::Connected);
  setState(remotePlayback, WebRemotePlaybackState::Disconnected);
  setState(remotePlayback, WebRemotePlaybackState::Disconnected);

to check that it doesn't fire a second disconnected event?

[whywhat, 2016-10-13 15:39:21]

Added extra state changes

[whywhat, 2016-10-13 15:39:32]

The CQ bit was checked by avayvod@chromium.org

[whywhat, 2016-10-13 15:39:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlamouri@chromium.org
Link to the patchset: https://codereview.chromium.org/2415443004/#ps40001
(title: "Added extra state changes")

[commit-bot: I haz the power, 2016-10-13 15:40:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 16:43:20]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-13 16:44:40]

Description was changed from

==========
[Blink, RemotePlayback]Split onstatechange to separate events

BUG=655340
TEST=Unit test + http://avayvod.github.io/remote-playback/test.html
==========

to

==========
[Blink, RemotePlayback]Split onstatechange to separate events

BUG=655340
TEST=Unit test + http://avayvod.github.io/remote-playback/test.html

Committed: https://crrev.com/7291ab8a6a4cef9b5eda1e04bd5f2578b86ad17f
Cr-Commit-Position: refs/heads/master@{#425057}
==========

[commit-bot: I haz the power, 2016-10-13 16:44:42]

Patchset 3 (id:??) landed as
https://crrev.com/7291ab8a6a4cef9b5eda1e04bd5f2578b86ad17f
Cr-Commit-Position: refs/heads/master@{#425057}