[Blink, RemotePlayback]Split onstatechange to separate events

third_party/WebKit/Source/modules/remoteplayback/RemotePlaybackTest.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/remoteplayback/RemotePlayback.h"
 
 #include "bindings/core/v8/ExceptionStatePlaceholder.h"
 #include "bindings/core/v8/V8BindingForTesting.h"
 #include "core/html/HTMLMediaElement.h"
 #include "core/html/HTMLVideoElement.h"
 #include "core/testing/DummyPageHolder.h"
 #include "platform/testing/UnitTestHelpers.h"
+#include "public/platform/modules/remoteplayback/WebRemotePlaybackState.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace blink {
 
 class MockFunction : public ScriptFunction {
  public:
   static MockFunction* create(ScriptState* scriptState) {
     return new MockFunction(scriptState);
   }
 
   v8::Local<v8::Function> bind() { return bindToV8Function(); }
 
   MOCK_METHOD1(call, ScriptValue(ScriptValue));
 
  private:
   explicit MockFunction(ScriptState* scriptState)
       : ScriptFunction(scriptState) {}
 };
 
+class MockEventListener : public EventListener {
+ public:
+  MockEventListener() : EventListener(CPPEventListenerType) {}
+
+  bool operator==(const EventListener& other) const final {
+    return this == &other;
+  }
+
+  MOCK_METHOD2(handleEvent, void(ExecutionContext* executionContext, Event*));
+};
+
 class RemotePlaybackTest : public ::testing::Test {
  protected:
   void cancelPrompt(RemotePlayback* remotePlayback) {
     remotePlayback->promptCancelled();
   }
+
+  void setState(RemotePlayback* remotePlayback, WebRemotePlaybackState state) {
+    remotePlayback->stateChanged(state);
+  }
 };
 
 TEST_F(RemotePlaybackTest, PromptCancelledRejectsWithNotAllowedError) {
   V8TestingScope scope;
 
   auto pageHolder = DummyPageHolder::create();
 
   HTMLMediaElement* element = HTMLVideoElement::create(pageHolder->document());
   RemotePlayback* remotePlayback = RemotePlayback::create(*element);
 
   MockFunction* resolve = MockFunction::create(scope.getScriptState());
   MockFunction* reject = MockFunction::create(scope.getScriptState());
 
   EXPECT_CALL(*resolve, call(::testing::_)).Times(0);
   EXPECT_CALL(*reject, call(::testing::_)).Times(1);
 
   remotePlayback->prompt(scope.getScriptState())
       .then(resolve->bind(), reject->bind());
   cancelPrompt(remotePlayback);
 }
 
+TEST_F(RemotePlaybackTest, StateChangeEvents) {
+  V8TestingScope scope;
+
+  auto pageHolder = DummyPageHolder::create();
+
+  HTMLMediaElement* element = HTMLVideoElement::create(pageHolder->document());
+  RemotePlayback* remotePlayback = RemotePlayback::create(*element);
+
+  auto connectingHandler = new ::testing::StrictMock<MockEventListener>();
+  auto connectHandler = new ::testing::StrictMock<MockEventListener>();
+  auto disconnectHandler = new ::testing::StrictMock<MockEventListener>();
+
+  remotePlayback->addEventListener(EventTypeNames::connecting,
+                                   connectingHandler);
+  remotePlayback->addEventListener(EventTypeNames::connect, connectHandler);
+  remotePlayback->addEventListener(EventTypeNames::disconnect,
+                                   disconnectHandler);
+
+  EXPECT_CALL(*connectingHandler, handleEvent(::testing::_, ::testing::_))
+      .Times(1);
+  EXPECT_CALL(*connectHandler, handleEvent(::testing::_, ::testing::_))
+      .Times(1);
+  EXPECT_CALL(*disconnectHandler, handleEvent(::testing::_, ::testing::_))
+      .Times(1);
+
+  setState(remotePlayback, WebRemotePlaybackState::Connecting);
+  setState(remotePlayback, WebRemotePlaybackState::Connected);
+  setState(remotePlayback, WebRemotePlaybackState::Disconnected);

[mlamouri (slow - plz ping), 2016/10/13 14:37:45]

Can you add double-calls? Like:

  setState(remotePlayback, WebRemotePlaybackState::Connecting);
  setState(remotePlayback, WebRemotePlaybackState::Connected);
  setState(remotePlayback, WebRemotePlaybackState::Disconnected);
  setState(remotePlayback, WebRemotePlaybackState::Disconnected);

to check that it doesn't fire a second disconnected event?

+}
+
 }  // namespace blink