Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 2415383002: [regexp] Match spec semantics in AdvanceStringIndex (Closed)

Created:
4 years, 2 months ago by jgruber
Modified:
4 years, 2 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] Match spec semantics in AdvanceStringIndex Let AdvanceStringIndex return the incremented index instead of the increment, and adjust all use sites. BUG=v8:5339 Committed: https://crrev.com/fa28281266555af432e685a7810e254b42951a77 Cr-Commit-Position: refs/heads/master@{#40310}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -12 lines) Patch
M src/builtins/builtins-regexp.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/regexp/regexp-utils.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/regexp/regexp-utils.cc View 2 chunks +3 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
jgruber
4 years, 2 months ago (2016-10-14 08:49:07 UTC) #4
Yang
lgtm
4 years, 2 months ago (2016-10-14 11:31:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2415383002/1
4 years, 2 months ago (2016-10-14 11:44:26 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-14 11:49:06 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 11:49:35 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fa28281266555af432e685a7810e254b42951a77
Cr-Commit-Position: refs/heads/master@{#40310}

Powered by Google App Engine
This is Rietveld 408576698