Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: src/builtins/builtins-regexp.cc

Issue 2415383002: [regexp] Match spec semantics in AdvanceStringIndex (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/regexp/regexp-utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/builtins/builtins-regexp.cc
diff --git a/src/builtins/builtins-regexp.cc b/src/builtins/builtins-regexp.cc
index fa7241941d7cc90d7a42025b405aa5f664657fd6..d96a9b7ca97fc55a2507a17006e28919db85fa3a 100644
--- a/src/builtins/builtins-regexp.cc
+++ b/src/builtins/builtins-regexp.cc
@@ -1400,8 +1400,8 @@ BUILTIN(RegExpPrototypeSplit) {
factory->undefined_value()));
if (result->IsNull(isolate)) {
- string_index += RegExpUtils::AdvanceStringIndex(isolate, string,
- string_index, unicode);
+ string_index = RegExpUtils::AdvanceStringIndex(isolate, string,
+ string_index, unicode);
continue;
}
@@ -1416,8 +1416,8 @@ BUILTIN(RegExpPrototypeSplit) {
const int end = std::min(last_index, length);
if (end == prev_string_index) {
- string_index += RegExpUtils::AdvanceStringIndex(isolate, string,
- string_index, unicode);
+ string_index = RegExpUtils::AdvanceStringIndex(isolate, string,
+ string_index, unicode);
continue;
}
« no previous file with comments | « no previous file | src/regexp/regexp-utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698