Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(811)

Issue 2415353002: Add boundary test case to StringToDouble (Closed)

Created:
4 years, 2 months ago by kcwu
Modified:
4 years, 2 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, jshin+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add boundary test case to StringToDouble The max presentable double is HUGE_VAL=(2^53-1)*(2^971). And (2^53)*(2^971) is considered overflow. Added cases above and below (2^53-0.5)*(2^971). The value above is overflow and the value below is not. std::strtod on linux doesn't pass the above case (it returns inf correctly but doesn't set errno=ERANGE). BUG=593512 Committed: https://crrev.com/7bd66b6c465395634479807d17b5d1cf9f5ac6d6 Cr-Commit-Position: refs/heads/master@{#425496}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M base/strings/string_number_conversions_unittest.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
kcwu
4 years, 2 months ago (2016-10-14 05:00:17 UTC) #2
Lei Zhang
lgtm
4 years, 2 months ago (2016-10-14 22:22:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2415353002/1
4 years, 2 months ago (2016-10-14 22:22:38 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-14 22:37:53 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 22:41:40 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7bd66b6c465395634479807d17b5d1cf9f5ac6d6
Cr-Commit-Position: refs/heads/master@{#425496}

Powered by Google App Engine
This is Rietveld 408576698