Reland V8: Run simple-leak-check step on release and trybot

Reland V8: Run simple-leak-check step on release and trybot

Prepared by:
https://codereview.chromium.org/2423083002/
https://codereview.chromium.org/2427603002/

BUG=656573
TBR=tandrii@chromium.org

Committed: https://chromium.googlesource.com/chromium/tools/build/+/d44afde07794016523aceefdd1de603fc2f75459
Committed: https://chromium.googlesource.com/chromium/tools/build/+/0cb76c4e79c13e8f742769452cc47a856373f352

[Michael Achenbach, 2016-10-14 13:07:28]

machenbach@chromium.org changed reviewers:
+ tandrii@chromium.org

[Michael Achenbach, 2016-10-14 13:07:29]

PTAL

This runs only on the main waterfall in debug and errors are not found by the
CQ:
https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20debug/buil...

There's no good reason to not run it on CQ and in release mode as well, since it
supports swarming. The extra deps will be in the git cache on each bot
eventually.

[tandrii(chromium), 2016-10-14 14:00:04]

lgtm

makes sense.

[Michael Achenbach, 2016-10-17 07:04:49]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2016-10-17 07:05:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 07:14:18]

Description was changed from

==========
V8: Run simple-leak-check step on release and trybot

BUG=
==========

to

==========
V8: Run simple-leak-check step on release and trybot

BUG=

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/d44afde07794016523ac...
==========

[commit-bot: I haz the power, 2016-10-17 07:14:19]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/d44afde07794016523ac...

[Michael Achenbach, 2016-10-17 08:02:03]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2423013002/ by machenbach@chromium.org.

The reason for reverting is: Fails on bots:
https://build.chromium.org/p/client.v8/builders/V8%20Linux64/builds/13571
.

[Michael Achenbach, 2016-10-17 11:16:34]

On 2016/10/17 08:02:03, machenbach (slow) wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/2423013002/ by mailto:machenbach@chromium.org.
> 
> The reason for reverting is: Fails on bots:
> https://build.chromium.org/p/client.v8/builders/V8%20Linux64/builds/13571
> .

This requires a 3-way dance, deps'ing valgrind on the bots, adding the config to
v8-side gn, then activating the tests. Tracking this here:
https://bugs.chromium.org/p/chromium/issues/detail?id=656573

[Michael Achenbach, 2016-10-17 18:39:30]

Description was changed from

==========
V8: Run simple-leak-check step on release and trybot

BUG=

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/d44afde07794016523ac...
==========

to

==========
V8: Run simple-leak-check step on release and trybot

BUG=

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/d44afde07794016523ac...
==========

[Michael Achenbach, 2016-10-17 18:47:06]

Description was changed from

==========
V8: Run simple-leak-check step on release and trybot

BUG=

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/d44afde07794016523ac...
==========

to

==========
Reland V8: Run simple-leak-check step on release and trybot

Prepared by:
https://codereview.chromium.org/2423083002/
https://codereview.chromium.org/2427603002/

BUG=656573
TBR=tandrii@chromium.org

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/d44afde07794016523ac...
==========

[Michael Achenbach, 2016-10-17 18:48:08]

PTAL at patch 2. Split-off preparations landed in separate CLs.

[Michael Achenbach, 2016-10-17 19:03:42]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 19:03:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 19:13:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 19:13:24]

Dry run: This issue passed the CQ dry run.

[Michael Achenbach, 2016-10-18 06:16:56]

The CQ bit was checked by machenbach@chromium.org

[Michael Achenbach, 2016-10-18 06:16:56]

The patchset sent to the CQ was uploaded after l-g-t-m from tandrii@chromium.org
Link to the patchset: https://codereview.chromium.org/2415243003/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2016-10-18 06:16:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 06:26:36]

Description was changed from

==========
Reland V8: Run simple-leak-check step on release and trybot

Prepared by:
https://codereview.chromium.org/2423083002/
https://codereview.chromium.org/2427603002/

BUG=656573
TBR=tandrii@chromium.org

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/d44afde07794016523ac...
==========

to

==========
Reland V8: Run simple-leak-check step on release and trybot

Prepared by:
https://codereview.chromium.org/2423083002/
https://codereview.chromium.org/2427603002/

BUG=656573
TBR=tandrii@chromium.org

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/d44afde07794016523ac...
Committed:
https://chromium.googlesource.com/chromium/tools/build/+/0cb76c4e79c13e8f7427...
==========

[commit-bot: I haz the power, 2016-10-18 06:26:39]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/0cb76c4e79c13e8f7427...