scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_rel_ng.json - Issue 2415243003: Reland V8: Run simple-leak-check step on release and trybot

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_rel_ng.json

Issue 2415243003: Reland V8: Run simple-leak-check step on release and trybot (Closed)

Patch Set: Rebase Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_one_failure_build_env_not_supported.json ('k') | scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_rel_ng_triggered.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_rel_ng.json

diff --git a/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_rel_ng.json b/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_rel_ng.json

index c105ed2534651eed96daab78c90f0c41bf9840fb..4dc279f0c255fbbad9f915941aa54f094b3cc82f 100644

--- a/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_rel_ng.json

+++ b/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_rel_ng.json

@@ -146,7 +146,7 @@

"env": {

"GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json",

"GYP_CHROMIUM_NO_ACTION": "1",

- "GYP_DEFINES": "dcheck_always_on=1 fastbuild=1 gomadir='[CACHE]/cipd/goma' target_arch=x64 test_isolation_mode=prepare use_goma=1 v8_target_arch=x64",

+ "GYP_DEFINES": "dcheck_always_on=1 fastbuild=1 gomadir='[CACHE]/cipd/goma' has_valgrind=1 target_arch=x64 test_isolation_mode=prepare use_goma=1 v8_target_arch=x64",

"GYP_GENERATORS": "ninja",

"PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"

@@ -331,6 +331,7 @@

"[SLAVE_BUILD]/v8/out/Release/check-static-initializers.isolated.gen.json",

"[SLAVE_BUILD]/v8/out/Release/mjsunit.isolated.gen.json",

"[SLAVE_BUILD]/v8/out/Release/optimize_for_size.isolated.gen.json",

+ "[SLAVE_BUILD]/v8/out/Release/run-valgrind.isolated.gen.json",

"[SLAVE_BUILD]/v8/out/Release/simdjs.isolated.gen.json",

"[SLAVE_BUILD]/v8/out/Release/test262.isolated.gen.json"

@@ -341,6 +342,7 @@

"@@@STEP_LOG_LINE@json.output@ \"check-static-initializers\": \"[dummy hash for check-static-initializers]\", @@@",

"@@@STEP_LOG_LINE@json.output@ \"mjsunit\": \"[dummy hash for mjsunit]\", @@@",

"@@@STEP_LOG_LINE@json.output@ \"optimize_for_size\": \"[dummy hash for optimize_for_size]\", @@@",

+ "@@@STEP_LOG_LINE@json.output@ \"run-valgrind\": \"[dummy hash for run-valgrind]\", @@@",

"@@@STEP_LOG_LINE@json.output@ \"simdjs\": \"[dummy hash for simdjs]\", @@@",

"@@@STEP_LOG_LINE@json.output@ \"test262\": \"[dummy hash for test262]\"@@@",

"@@@STEP_LOG_LINE@json.output@}@@@",

@@ -375,6 +377,7 @@

"check-static-initializers": "[dummy hash for check-static-initializers]",

"mjsunit": "[dummy hash for mjsunit]",

"optimize_for_size": "[dummy hash for optimize_for_size]",

+ "run-valgrind": "[dummy hash for run-valgrind]",

"simdjs": "[dummy hash for simdjs]",

"test262": "[dummy hash for test262]"

}