Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2415233002: Adding 'Always on top' behavior to the It2Me Confirmation Dialog (Closed)

Created:
4 years, 2 months ago by joedow
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Adding 'Always on top' behavior to the It2Me Confirmation Dialog This CL sets a flag on the It2MeConfirmationDialog created on Windows which causes it to be displayed as a top-level window. I've also added a call to ensure the dialog is above any other top-level window. These two changes will ensure the dialog is displayed over the other windows on the desktop, regardless of whethet they are topmost windows or not. BUG=654938 Review-Url: https://codereview.chromium.org/2418613003 Cr-Commit-Position: refs/heads/master@{#424883} (cherry picked from commit 37d4966ef8a8e5cc5b83d7892f1622f679529d93) Committed: https://chromium.googlesource.com/chromium/src/+/a6d9de9917174149fe5ad52188105b4f99a973ff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M remoting/host/it2me/it2me_confirmation_dialog_win.cc View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
joedow
4 years, 2 months ago (2016-10-13 21:50:57 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a6d9de9917174149fe5ad52188105b4f99a973ff.

Powered by Google App Engine
This is Rietveld 408576698