Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1000)

Issue 2418613003: Adding 'Always on top' behavior to the It2Me Confirmation Dialog (Closed)

Created:
4 years, 2 months ago by joedow
Modified:
4 years, 2 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding 'Always on top' behavior to the It2Me Confirmation Dialog This CL sets a flag on the It2MeConfirmationDialog created on Windows which causes it to be displayed as a top-level window. I've also added a call to ensure the dialog is above any other top-level window. These two changes will ensure the dialog is displayed over the other windows on the desktop, regardless of whethet they are topmost windows or not. BUG=654938 Committed: https://crrev.com/37d4966ef8a8e5cc5b83d7892f1622f679529d93 Cr-Commit-Position: refs/heads/master@{#424883}

Patch Set 1 #

Patch Set 2 : Updating comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M remoting/host/it2me/it2me_confirmation_dialog_win.cc View 1 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
joedow
PTAL!
4 years, 2 months ago (2016-10-12 21:57:51 UTC) #4
Jamie
LGTM!
4 years, 2 months ago (2016-10-12 22:02:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2418613003/20001
4 years, 2 months ago (2016-10-12 22:22:02 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-12 22:30:56 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 22:32:31 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/37d4966ef8a8e5cc5b83d7892f1622f679529d93
Cr-Commit-Position: refs/heads/master@{#424883}

Powered by Google App Engine
This is Rietveld 408576698