[regexp] Turn last match info into a simple FixedArray

[regexp] Turn last match info into a simple FixedArray

Now that all accesses to the last match info are in C++ and TF code, we can
finally turn the last match info into a FixedArray. Similar to the ArrayList,
it uses its first field to store its length and grows dynamically in amortized
O(1) time.

Unlike previously, this means that the last match info pointer stored on the
context can actually change (in case the FixedArray needs to grow).

BUG=v8:5339
Committed: https://crrev.com/f60a7c4f61b15341c3bc7bb46a41c13a090f7789
Cr-Commit-Position: refs/heads/master@{#40308}

[jgruber, 2016-10-13 15:03:51]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 15:04:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2016-10-13 15:06:15]

jgruber@chromium.org changed reviewers:
+ yangguo@chromium.org

[jgruber, 2016-10-13 15:06:15]

PTAL. Architectures other than x64 still need to be ported.

I'll move the internal match info to the context in a follow-up commit.

[commit-bot: I haz the power, 2016-10-13 15:09:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 15:09:36]

Dry run: Try jobs failed on following builders:
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/10769)

[jgruber, 2016-10-14 06:48:35]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 06:48:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 06:52:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 06:52:30]

Dry run: Try jobs failed on following builders:
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)

[jgruber, 2016-10-14 08:08:58]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 08:09:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2016-10-14 08:09:55]

jgruber@chromium.org changed reviewers:
+ bmeurer@chromium.org

[jgruber, 2016-10-14 08:09:56]

All architectures are now ported, and moved internal match info to context.
+bmeurer for RegExpExecStub.

[commit-bot: I haz the power, 2016-10-14 08:13:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 08:13:59]

Dry run: Try jobs failed on following builders:
  v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)

[jgruber, 2016-10-14 08:23:47]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 08:23:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Benedikt Meurer, 2016-10-14 08:33:12]

LGTM (rubber-stamped)

[commit-bot: I haz the power, 2016-10-14 08:35:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 08:35:36]

Dry run: Try jobs failed on following builders:
  v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/2...)

[Yang, 2016-10-14 08:51:10]

https://codereview.chromium.org/2415103002/diff/40001/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):

https://codereview.chromium.org/2415103002/diff/40001/src/arm/code-stubs-arm....
src/arm/code-stubs-arm.cc:1504: __ CompareRoot(r0,
Heap::kFixedArrayMapRootIndex);
I don't think we have to first check that the elements have FIXED_ARRAY_TYPE for
instance type and then also do a map check. I think the map check alone is
sufficient.

[jgruber, 2016-10-14 09:11:31]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 09:11:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2016-10-14 09:15:18]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 09:15:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 09:47:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 09:47:16]

Dry run: This issue passed the CQ dry run.

[jgruber, 2016-10-14 09:52:15]

PTAL

https://codereview.chromium.org/2415103002/diff/40001/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):

https://codereview.chromium.org/2415103002/diff/40001/src/arm/code-stubs-arm....
src/arm/code-stubs-arm.cc:1504: __ CompareRoot(r0,
Heap::kFixedArrayMapRootIndex);
On 2016/10/14 08:51:10, Yang wrote:
> I don't think we have to first check that the elements have FIXED_ARRAY_TYPE
for
> instance type and then also do a map check. I think the map check alone is
> sufficient.

Done.

[Yang, 2016-10-14 11:15:00]

lgtm

[jgruber, 2016-10-14 11:43:50]

The CQ bit was checked by jgruber@chromium.org

[jgruber, 2016-10-14 11:43:50]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/2415103002/#ps100001
(title: "Don't check instance type before map check")

[commit-bot: I haz the power, 2016-10-14 11:43:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 11:46:50]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-10-14 11:47:15]

Description was changed from

==========
[regexp] Turn last match info into a simple FixedArray

Now that all accesses to the last match info are in C++ and TF code, we can
finally turn the last match info into a FixedArray. Similar to the ArrayList,
it uses its first field to store its length and grows dynamically in amortized
O(1) time.

Unlike previously, this means that the last match info pointer stored on the
context can actually change (in case the FixedArray needs to grow).

BUG=v8:5339
==========

to

==========
[regexp] Turn last match info into a simple FixedArray

Now that all accesses to the last match info are in C++ and TF code, we can
finally turn the last match info into a FixedArray. Similar to the ArrayList,
it uses its first field to store its length and grows dynamically in amortized
O(1) time.

Unlike previously, this means that the last match info pointer stored on the
context can actually change (in case the FixedArray needs to grow).

BUG=v8:5339

Committed: https://crrev.com/f60a7c4f61b15341c3bc7bb46a41c13a090f7789
Cr-Commit-Position: refs/heads/master@{#40308}
==========

[commit-bot: I haz the power, 2016-10-14 11:47:16]

Patchset 6 (id:??) landed as
https://crrev.com/f60a7c4f61b15341c3bc7bb46a41c13a090f7789
Cr-Commit-Position: refs/heads/master@{#40308}