[regexp] Turn last match info into a simple FixedArray

src/regexp/regexp-utils.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/regexp/regexp-utils.h"
 
 #include "src/factory.h"
 #include "src/isolate.h"
 #include "src/objects-inl.h"
 #include "src/regexp/jsregexp.h"
 
 namespace v8 {
 namespace internal {
 
-// Constants for accessing RegExpLastMatchInfo.
-// TODO(jgruber): Currently, RegExpLastMatchInfo is still a JSObject maintained
-// and accessed from JS. This is a crutch until all RegExp logic is ported, then
-// we can take care of RegExpLastMatchInfo.
-
-Handle<Object> RegExpUtils::GetLastMatchField(Isolate* isolate,
-                                              Handle<JSObject> match_info,
-                                              int index) {
-  return JSReceiver::GetElement(isolate, match_info, index).ToHandleChecked();
-}
-
-void RegExpUtils::SetLastMatchField(Isolate* isolate,
-                                    Handle<JSObject> match_info, int index,
-                                    Handle<Object> value) {
-  JSReceiver::SetElement(isolate, match_info, index, value, SLOPPY)
-      .ToHandleChecked();
-}
-
-int RegExpUtils::GetLastMatchNumberOfCaptures(Isolate* isolate,
-                                              Handle<JSObject> match_info) {
-  Handle<Object> obj =
-      GetLastMatchField(isolate, match_info, RegExpImpl::kLastCaptureCount);
-  return Handle<Smi>::cast(obj)->value();
-}
-
-Handle<String> RegExpUtils::GetLastMatchSubject(Isolate* isolate,
-                                                Handle<JSObject> match_info) {
-  return Handle<String>::cast(
-      GetLastMatchField(isolate, match_info, RegExpImpl::kLastSubject));
-}
-
-Handle<Object> RegExpUtils::GetLastMatchInput(Isolate* isolate,
-                                              Handle<JSObject> match_info) {
-  return GetLastMatchField(isolate, match_info, RegExpImpl::kLastInput);
-}
-
-int RegExpUtils::GetLastMatchCapture(Isolate* isolate,
-                                     Handle<JSObject> match_info, int i) {
-  Handle<Object> obj =
-      GetLastMatchField(isolate, match_info, RegExpImpl::kFirstCapture + i);
-  return Handle<Smi>::cast(obj)->value();
-}
-
-Handle<String> RegExpUtils::GenericCaptureGetter(Isolate* isolate,
-                                                 Handle<JSObject> match_info,
-                                                 int capture, bool* ok) {
+Handle<String> RegExpUtils::GenericCaptureGetter(
+    Isolate* isolate, Handle<RegExpMatchInfo> match_info, int capture,
+    bool* ok) {
   const int index = capture * 2;
-  if (index >= GetLastMatchNumberOfCaptures(isolate, match_info)) {
+  if (index >= match_info->NumberOfCaptureRegisters()) {
     if (ok != nullptr) *ok = false;
     return isolate->factory()->empty_string();
   }
 
-  const int match_start = GetLastMatchCapture(isolate, match_info, index);
-  const int match_end = GetLastMatchCapture(isolate, match_info, index + 1);
+  const int match_start = match_info->Capture(index);
+  const int match_end = match_info->Capture(index + 1);
   if (match_start == -1 || match_end == -1) {
     if (ok != nullptr) *ok = false;
     return isolate->factory()->empty_string();
   }
 
   if (ok != nullptr) *ok = true;
-  Handle<String> last_subject = GetLastMatchSubject(isolate, match_info);
+  Handle<String> last_subject(match_info->LastSubject());
   return isolate->factory()->NewSubString(last_subject, match_start, match_end);
 }
 
 namespace {
 
 V8_INLINE bool HasInitialRegExpMap(Isolate* isolate, Handle<JSReceiver> recv) {
   return recv->map() == isolate->regexp_function()->initial_map();
 }
 
 }  // namespace
@@ skipping 135 matching lines @@
 
   const int last_index = Handle<Smi>::cast(last_index_obj)->value();
   const int new_last_index =
       last_index + AdvanceStringIndex(isolate, string, last_index, unicode);
 
   return SetLastIndex(isolate, regexp, new_last_index);
 }
 
 }  // namespace internal
 }  // namespace v8