Issue 24150004: Refactor the setup of Shill*Stubs' default environment.

Issue 24150004: Refactor the setup of Shill*Stubs' default environment. (Closed)

Created:
7 years, 3 months ago by pneubeck (no reviews)

Modified:
7 years, 3 months ago

Reviewers:
stevenjb

CC:
chromium-reviews, cbentzel+watch_chromium.org, nkostylev+watch_chromium.org, gspencer+watch_chromium.org, gauravsh+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Refactor the setup of Shill*Stubs' default environment. This change untangles some of the Shill*Stubs' implementation from the setup of a default network environment. In particular the setup function has now access to all Shill*Stubs during this setup. This also correctly adds stub networks with status 'online' to a profile, so that the respective FavoriteState is created. BUG=126870 R=stevenjb@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224756

Patch Set 1 : #

Total comments: 1

Patch Set 2 : Renamed to shill_stub_helper #

Patch Set 3 : Fixed some includes. #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+319 lines, -228 lines)			Patch
M	chrome/browser/chromeos/net/network_portal_detector_impl.cc	View	1	2 chunks	+2 lines, -3 lines	0 comments	Download
M	chromeos/chromeos.gyp	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chromeos/dbus/dbus_thread_manager.cc	View	1	4 chunks	+9 lines, -17 lines	0 comments	Download
M	chromeos/dbus/shill_device_client_stub.cc	View		2 chunks	+1 line, -20 lines	0 comments	Download
M	chromeos/dbus/shill_manager_client_stub.cc	View	1 2	3 chunks	+1 line, -15 lines	0 comments	Download
M	chromeos/dbus/shill_profile_client_stub.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	chromeos/dbus/shill_profile_client_stub.cc	View		2 chunks	+0 lines, -4 lines	0 comments	Download
M	chromeos/dbus/shill_service_client.h	View		2 chunks	+3 lines, -4 lines	0 comments	Download
M	chromeos/dbus/shill_service_client_stub.h	View		4 chunks	+11 lines, -7 lines	0 comments	Download
M	chromeos/dbus/shill_service_client_stub.cc	View	1 2	12 chunks	+61 lines, -153 lines	0 comments	Download
A	chromeos/dbus/shill_stub_helper.h	View	1	1 chunk	+28 lines, -0 lines	0 comments	Download
A	chromeos/dbus/shill_stub_helper.cc	View	1	1 chunk	+198 lines, -0 lines	0 comments	Download
M	chromeos/network/network_configuration_handler_unittest.cc	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

pneubeck (no reviews)

PTAL, this is required to fix FavoriteState in tests which is in turn required for ...

7 years, 3 months ago (2013-09-20 15:15:40 UTC) #1

stevenjb

Nice cleanup, thanks for doing this. LGTM with name change suggestion. https://codereview.chromium.org/24150004/diff/14001/chromeos/dbus/shill_test_helper.h File chromeos/dbus/shill_test_helper.h (right): ...

7 years, 3 months ago (2013-09-20 17:46:05 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/24150004/33001

7 years, 3 months ago (2013-09-23 08:00:53 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) chrome_frame_net_tests, chrome_frame_tests, chrome_frame_unittests, content_browsertests, mini_installer_test, nacl_integration, ...

7 years, 3 months ago (2013-09-23 10:06:20 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/24150004/33001

7 years, 3 months ago (2013-09-23 10:42:22 UTC) #5

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=201058

7 years, 3 months ago (2013-09-23 15:16:16 UTC) #6

pneubeck (no reviews)

7 years, 3 months ago (2013-09-23 18:49:50 UTC) #7

Message was sent while issue was closed.

Committed patchset #3 manually as r224756 (presubmit successful).

Expand Messages | Collapse Messages