Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: chromeos/dbus/shill_device_client_stub.cc

Issue 24150004: Refactor the setup of Shill*Stubs' default environment. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed some includes. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/dbus/dbus_thread_manager.cc ('k') | chromeos/dbus/shill_manager_client_stub.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/dbus/shill_device_client_stub.cc
diff --git a/chromeos/dbus/shill_device_client_stub.cc b/chromeos/dbus/shill_device_client_stub.cc
index a32febd59a1c1062f3056071fcd5d266f5808bf2..c58ed2354a14c5c51593df84ccc30a80e88b256e 100644
--- a/chromeos/dbus/shill_device_client_stub.cc
+++ b/chromeos/dbus/shill_device_client_stub.cc
@@ -39,9 +39,7 @@ ShillDeviceClientStub::~ShillDeviceClientStub() {
// ShillDeviceClient overrides.
-void ShillDeviceClientStub::Init(dbus::Bus* bus) {
- SetDefaultProperties();
-}
+void ShillDeviceClientStub::Init(dbus::Bus* bus) {}
void ShillDeviceClientStub::AddPropertyChangedObserver(
const dbus::ObjectPath& device_path,
@@ -234,23 +232,6 @@ std::string ShillDeviceClientStub::GetDevicePathForType(
return std::string();
}
-void ShillDeviceClientStub::SetDefaultProperties() {
- // Add a wifi device.
- AddDevice("stub_wifi_device1", flimflam::kTypeWifi, "/device/wifi1");
-
- // Add a cellular device. Used in SMS stub.
- AddDevice("stub_cellular_device1", flimflam::kTypeCellular,
- "/device/cellular1");
- base::DictionaryValue* properties =
- GetDeviceProperties("stub_cellular_device1");
- properties->SetStringWithoutPathExpansion(flimflam::kCarrierProperty,
- shill::kCarrierSprint);
-
- // Add a wimax device.
- AddDevice("stub_wimax_device1", flimflam::kTypeWimax,
- "/device/wimax1");
-}
-
void ShillDeviceClientStub::PassStubDeviceProperties(
const dbus::ObjectPath& device_path,
const DictionaryValueCallback& callback) const {
« no previous file with comments | « chromeos/dbus/dbus_thread_manager.cc ('k') | chromeos/dbus/shill_manager_client_stub.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698