Inform WebContents when a password field is visible

Inform WebContents when a password field is visible

Previously, ContentPasswordManagerDriver was notifying the WebContents
whenever a password field was parsed. Instead, we want to notify the
WebContents whenever a password field becomes visible. This CL moves the
WebContents notification from PasswordFormsParsed() to
PasswordFieldVisibleInInsecureContext().

BUG=647560
TEST=New unit test checks that ContentPasswordManagerDriver correctly
passes the password visibility notification to the
WebContents. Pre-existing browser tests in
chrome_security_state_model_client_browsertest.cc check that everything
is hooked up correctly (i.e. when Blink sends a password visibility
message, it is received by ContentPasswordManagerDriver, passed on to
the WebContents, which records it on the SSLStatus).

Committed: https://crrev.com/98182cd39250bf946e34c5da63eaf4d5afcd77af
Cr-Commit-Position: refs/heads/master@{#425046}

[estark, 2016-10-13 00:15:11]

The CQ bit was checked by estark@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 00:15:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[estark, 2016-10-13 00:16:37]

estark@chromium.org changed reviewers:
+ engedy@chromium.org

[estark, 2016-10-13 00:16:37]

engedy, could you please review? This is a follow-up to
https://codereview.chromium.org/2362523003/. Thanks!

[commit-bot: I haz the power, 2016-10-13 00:22:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 00:22:02]

Dry run: Exceeded global retry quota

[vabr (Chromium), 2016-10-13 09:11:40]

vabr@chromium.org changed reviewers:
+ vabr@chromium.org

[vabr (Chromium), 2016-10-13 09:11:40]

LGTM!
Vaclav

[engedy, 2016-10-13 12:47:59]

Description was changed from

==========
Inform WebContents when a password field is visible

Previously, ContentPasswordManagerDriver was notifying the WebContents
whenever a password field was parsed. Instead, we want to notify the
WebContents whenever a password field becomes visible. This CL moves the
WebContents notification from PasswordFormsParsed() to
PasswordFieldVisibleInInsecureContext().

BUG=647560
TEST=New unit test checks that ContentPasswordManagerDriver correctly
passes the password visibility notification to the
WebContents. Pre-existing browser tests in
chrome_security_state_model_client_browsertest.cc check that everything
is hooked up correctly (i.e. when Blink sends a password visibility
message, it is received by ContentPasswordManagerDriver, passed on to
the WebContents, which records it on the SSLStatus).
==========

to

==========
Inform WebContents when a password field is visible

Previously, ContentPasswordManagerDriver was notifying the WebContents
whenever a password field was parsed. Instead, we want to notify the
WebContents whenever a password field becomes visible. This CL moves the
WebContents notification from PasswordFormsParsed() to
PasswordFieldVisibleInInsecureContext().

BUG=647560
TEST=New unit test checks that ContentPasswordManagerDriver correctly
passes the password visibility notification to the
WebContents. Pre-existing browser tests in
chrome_security_state_model_client_browsertest.cc check that everything
is hooked up correctly (i.e. when Blink sends a password visibility
message, it is received by ContentPasswordManagerDriver, passed on to
the WebContents, which records it on the SSLStatus).
==========

[engedy, 2016-10-13 12:47:59]

engedy@chromium.org changed reviewers:
- engedy@chromium.org

[engedy, 2016-10-13 12:48:15]

On 2016/10/13 09:11:40, vabr (Chromium) wrote:
> LGTM!
> Vaclav

If it looks good to Vaclav then it looks good to me.

[estark, 2016-10-13 15:48:21]

Thanks, vabr and engedy!

[estark, 2016-10-13 15:48:26]

The CQ bit was checked by estark@chromium.org

[commit-bot: I haz the power, 2016-10-13 15:48:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 15:55:32]

Description was changed from

==========
Inform WebContents when a password field is visible

Previously, ContentPasswordManagerDriver was notifying the WebContents
whenever a password field was parsed. Instead, we want to notify the
WebContents whenever a password field becomes visible. This CL moves the
WebContents notification from PasswordFormsParsed() to
PasswordFieldVisibleInInsecureContext().

BUG=647560
TEST=New unit test checks that ContentPasswordManagerDriver correctly
passes the password visibility notification to the
WebContents. Pre-existing browser tests in
chrome_security_state_model_client_browsertest.cc check that everything
is hooked up correctly (i.e. when Blink sends a password visibility
message, it is received by ContentPasswordManagerDriver, passed on to
the WebContents, which records it on the SSLStatus).
==========

to

==========
Inform WebContents when a password field is visible

Previously, ContentPasswordManagerDriver was notifying the WebContents
whenever a password field was parsed. Instead, we want to notify the
WebContents whenever a password field becomes visible. This CL moves the
WebContents notification from PasswordFormsParsed() to
PasswordFieldVisibleInInsecureContext().

BUG=647560
TEST=New unit test checks that ContentPasswordManagerDriver correctly
passes the password visibility notification to the
WebContents. Pre-existing browser tests in
chrome_security_state_model_client_browsertest.cc check that everything
is hooked up correctly (i.e. when Blink sends a password visibility
message, it is received by ContentPasswordManagerDriver, passed on to
the WebContents, which records it on the SSLStatus).
==========

[commit-bot: I haz the power, 2016-10-13 15:55:33]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-13 15:57:47]

Description was changed from

==========
Inform WebContents when a password field is visible

Previously, ContentPasswordManagerDriver was notifying the WebContents
whenever a password field was parsed. Instead, we want to notify the
WebContents whenever a password field becomes visible. This CL moves the
WebContents notification from PasswordFormsParsed() to
PasswordFieldVisibleInInsecureContext().

BUG=647560
TEST=New unit test checks that ContentPasswordManagerDriver correctly
passes the password visibility notification to the
WebContents. Pre-existing browser tests in
chrome_security_state_model_client_browsertest.cc check that everything
is hooked up correctly (i.e. when Blink sends a password visibility
message, it is received by ContentPasswordManagerDriver, passed on to
the WebContents, which records it on the SSLStatus).
==========

to

==========
Inform WebContents when a password field is visible

Previously, ContentPasswordManagerDriver was notifying the WebContents
whenever a password field was parsed. Instead, we want to notify the
WebContents whenever a password field becomes visible. This CL moves the
WebContents notification from PasswordFormsParsed() to
PasswordFieldVisibleInInsecureContext().

BUG=647560
TEST=New unit test checks that ContentPasswordManagerDriver correctly
passes the password visibility notification to the
WebContents. Pre-existing browser tests in
chrome_security_state_model_client_browsertest.cc check that everything
is hooked up correctly (i.e. when Blink sends a password visibility
message, it is received by ContentPasswordManagerDriver, passed on to
the WebContents, which records it on the SSLStatus).

Committed: https://crrev.com/98182cd39250bf946e34c5da63eaf4d5afcd77af
Cr-Commit-Position: refs/heads/master@{#425046}
==========

[commit-bot: I haz the power, 2016-10-13 15:57:48]

Patchset 1 (id:??) landed as
https://crrev.com/98182cd39250bf946e34c5da63eaf4d5afcd77af
Cr-Commit-Position: refs/heads/master@{#425046}