components/password_manager/content/browser/content_password_manager_driver.cc - Issue 2414913003: Inform WebContents when a password field is visible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/content/browser/content_password_manager_driver.cc

Issue 2414913003: Inform WebContents when a password field is visible (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ssl/chrome_security_state_model_client_browser_tests.cc ('k') | components/password_manager/content/browser/content_password_manager_driver_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/content/browser/content_password_manager_driver.cc

diff --git a/components/password_manager/content/browser/content_password_manager_driver.cc b/components/password_manager/content/browser/content_password_manager_driver.cc

index c9854058af8dbb3a1117971df55cf8ae39e39ec3..b658e0bdf0d05e4a762a8a83c530587e4fff8010 100644

--- a/components/password_manager/content/browser/content_password_manager_driver.cc

+++ b/components/password_manager/content/browser/content_password_manager_driver.cc

@@ -174,7 +174,6 @@ void ContentPasswordManagerDriver::PasswordFormsParsed(

void ContentPasswordManagerDriver::OnPasswordFormsParsedNoRenderCheck(

const std::vector<autofill::PasswordForm>& forms) {

- MaybeNotifyPasswordInputShownOnHttp(render_frame_host_);

GetPasswordManager()->OnPasswordFormsParsed(this, forms);

GetPasswordGenerationManager()->CheckIfFormClassifierShouldRun();

}

@@ -209,9 +208,7 @@ void ContentPasswordManagerDriver::OnFocusedPasswordFormFound(

}

void ContentPasswordManagerDriver::PasswordFieldVisibleInInsecureContext() {

- // TODO(estark): notify the WebContents that a password field was

- // shown, which will downgrade the security UI

- // appropriately. https://crbug.com/647560

+ MaybeNotifyPasswordInputShownOnHttp(render_frame_host_);

}

void ContentPasswordManagerDriver::DidNavigateFrame(