Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 2414683004: [Merge to M54] Fix regression showing chrome logo in SAML signin title bar (Closed)

Created:
4 years, 2 months ago by afakhry
Modified:
4 years, 2 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, achuith+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

[Merge to M54] Fix regression showing chrome logo in SAML signin title bar A more specific CSS rule added recently overrides the less specific rules that hides that logo in various login screens. This CL adds the class no-logo to those screens for the display manager to hide that logo. TBR=xiyuan@chromium.org BUG=647043 TEST=Add a new user with a SAML-enabled account and make sure the unwanted logo doesn't show up. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2412253002 Cr-Commit-Position: refs/heads/master@{#424879} (cherry picked from commit 74307c9d468b802c64200aa07c96ba01248b3026) Committed: https://chromium.googlesource.com/chromium/src/+/31be6fad2470400b02b9bdd6d0a245a3b0670cdc

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
afakhry
4 years, 2 months ago (2016-10-13 17:06:48 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
31be6fad2470400b02b9bdd6d0a245a3b0670cdc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698