Fix regression showing chrome logo in SAML signin title bar

Fix regression showing chrome logo in SAML signin title bar

A more specific CSS rule added recently overrides the less specific
rules that hides that logo in various login screens. This CL adds the
class no-logo to those screens for the display manager to hide that logo.

BUG=647043
TEST=Add a new user with a SAML-enabled account and make sure the unwanted
logo doesn't show up.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/74307c9d468b802c64200aa07c96ba01248b3026
Cr-Commit-Position: refs/heads/master@{#424879}

[afakhry, 2016-10-12 20:28:20]

Description was changed from

==========
Fix regression showing chrome logo in SAML signin title bar

A more specific CSS rule added recently overrides the less specific
rules that hides that logo in various login screens. This CL adds the
class no-logo to those screens for the display manager to hide that logo.

BUG=647043
TEST=Add a new user with a SAML-enabled account and make sure the unwanted
logo doesn't show up.
==========

to

==========
Fix regression showing chrome logo in SAML signin title bar

A more specific CSS rule added recently overrides the less specific
rules that hides that logo in various login screens. This CL adds the
class no-logo to those screens for the display manager to hide that logo.

BUG=647043
TEST=Add a new user with a SAML-enabled account and make sure the unwanted
logo doesn't show up.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[afakhry, 2016-10-12 20:29:03]

afakhry@chromium.org changed reviewers:
+ xiyuan@chromium.org

[afakhry, 2016-10-12 20:29:03]

Xiyuan, please review. Thank you!

[xiyuan, 2016-10-12 20:55:38]

Can we also remove "display: none;" in the relevant css? Think it is not needed
when the screen div is marked with "no-logo".

[afakhry, 2016-10-12 21:16:24]

On 2016/10/12 20:55:38, xiyuan wrote:
> Can we also remove "display: none;" in the relevant css? Think it is not
needed
> when the screen div is marked with "no-logo".

Done.

[xiyuan, 2016-10-12 21:18:46]

lgtm

Cool. Thank you for fixing and cleaning up.

[afakhry, 2016-10-12 21:31:56]

The CQ bit was checked by afakhry@chromium.org

[commit-bot: I haz the power, 2016-10-12 21:32:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 22:20:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-12 22:22:40]

Description was changed from

==========
Fix regression showing chrome logo in SAML signin title bar

A more specific CSS rule added recently overrides the less specific
rules that hides that logo in various login screens. This CL adds the
class no-logo to those screens for the display manager to hide that logo.

BUG=647043
TEST=Add a new user with a SAML-enabled account and make sure the unwanted
logo doesn't show up.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Fix regression showing chrome logo in SAML signin title bar

A more specific CSS rule added recently overrides the less specific
rules that hides that logo in various login screens. This CL adds the
class no-logo to those screens for the display manager to hide that logo.

BUG=647043
TEST=Add a new user with a SAML-enabled account and make sure the unwanted
logo doesn't show up.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/74307c9d468b802c64200aa07c96ba01248b3026
Cr-Commit-Position: refs/heads/master@{#424879}
==========

[commit-bot: I haz the power, 2016-10-12 22:22:41]

Patchset 2 (id:??) landed as
https://crrev.com/74307c9d468b802c64200aa07c96ba01248b3026
Cr-Commit-Position: refs/heads/master@{#424879}