Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-hide-on-click-panel.html

Issue 2414653002: [MediaControls] Hide menus when clicking on some MediaControl elements (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/shadow/MediaControls.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-hide-on-click-panel.html
diff --git a/third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-hide-on-click.html b/third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-hide-on-click-panel.html
similarity index 90%
copy from third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-hide-on-click.html
copy to third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-hide-on-click-panel.html
index a1e7dd610ea6d4201ef281a54e272af7643cd810..241962a1a4133f56b36ff7f42e95a963261e6421 100644
--- a/third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-hide-on-click.html
+++ b/third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-hide-on-click-panel.html
@@ -14,13 +14,14 @@ async_test(function(t) {
// Set up video
var video = document.querySelector("video");
video.src = findMediaFile("video", "content/test");
- video.setAttribute("width", "60");
+ video.setAttribute("width", "200");
// Add captions
var track = video.addTextTrack("captions");
// Pretend we have a cast device
internals.mediaPlayerRemoteRouteAvailabilityChanged(video, true);
video.onloadeddata = t.step_func_done(function() {
+ var playButton = mediaControlsButton(video, "play-button");
var overflowList = getOverflowList(video);
var overflowMenu = getOverflowMenuButton(video);
@@ -30,7 +31,7 @@ async_test(function(t) {
assert_not_equals(getComputedStyle(overflowList).display, "none");
// Click on an overflow menu item should close overflow list.
- var coords = elementCoordinates(overflowList);
+ var coords = elementCoordinates(playButton);
clickAtCoordinates(coords[0], coords[1]);
assert_equals(getComputedStyle(overflowList).display, "none");
});
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/shadow/MediaControls.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698