Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 241453003: Reduce internal explicit SaveFlags usage. (Closed)

Created:
6 years, 8 months ago by f(malita)
Modified:
6 years, 8 months ago
Reviewers:
robertphillips, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Reduce internal explicit SaveFlags usage. Most of these are either redundant/defaults or (hopefully) unnecessarily specific. R=reed@google.com,robertphillips@google.com Committed: http://code.google.com/p/skia/source/detail?r=14253

Patch Set 1 #

Patch Set 2 : Re-added needed save flag in SkPictureStateTree::Iterator::draw() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -26 lines) Patch
M bench/DeferredCanvasBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/xfermodes.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/xfermodes2.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/xfermodes3.cpp View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleLayerMask.cpp View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleLayers.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M samplecode/SampleXfermodesBlur.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/animator/SkDrawSaveLayer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkCanvas.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M src/core/SkPictureRecord.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkPictureStateTree.cpp View 1 2 chunks +4 lines, -1 line 0 comments Download
M src/effects/SkLayerDrawLooper.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/DeferredCanvasTest.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M tests/ImageFilterTest.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
f(malita)
6 years, 8 months ago (2014-04-17 21:12:51 UTC) #1
reed1
lgtm
6 years, 8 months ago (2014-04-17 21:14:32 UTC) #2
f(malita)
On 2014/04/17 21:14:32, reed1 wrote: > lgtm I'll wait for the trybot herd to make ...
6 years, 8 months ago (2014-04-17 21:19:46 UTC) #3
f(malita)
On 2014/04/17 21:19:46, Florin Malita wrote: > On 2014/04/17 21:14:32, reed1 wrote: > > lgtm ...
6 years, 8 months ago (2014-04-17 23:28:26 UTC) #4
f(malita)
On 2014/04/17 23:28:26, Florin Malita wrote: > Hmm, there are (Linux-only?!) GM failures Mac too, ...
6 years, 8 months ago (2014-04-17 23:33:11 UTC) #5
f(malita)
The CQ bit was checked by fmalita@chromium.org
6 years, 8 months ago (2014-04-18 14:03:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/fmalita@chromium.org/241453003/20001
6 years, 8 months ago (2014-04-18 14:03:14 UTC) #7
commit-bot: I haz the power
6 years, 8 months ago (2014-04-18 14:19:37 UTC) #8
Message was sent while issue was closed.
Change committed as 14253

Powered by Google App Engine
This is Rietveld 408576698