gm/xfermodes.cpp - Issue 241453003: Reduce internal explicit SaveFlags usage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gm/xfermodes.cpp

Issue 241453003: Reduce internal explicit SaveFlags usage. (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Re-added needed save flag in SkPictureStateTree::Iterator::draw() Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gm/xfermodes.cpp

diff --git a/gm/xfermodes.cpp b/gm/xfermodes.cpp

index b5ce8b8ced8ad1ce2375d8b8a687c85bd1f17a3f..24c48ee74720b0bf3e486a9b43058fc67e13ef18 100644

--- a/gm/xfermodes.cpp

+++ b/gm/xfermodes.cpp

@@ -112,7 +112,7 @@ class XfermodesGM : public GM {

break;

}

case kRectangleWithMask_SrcType: {

- canvas->save(SkCanvas::kClip_SaveFlag);

+ canvas->save();

restoreNeeded = true;

SkScalar w = SkIntToScalar(W);

SkScalar h = SkIntToScalar(H);

@@ -247,7 +247,7 @@ protected:

p.setShader(s);

canvas->drawRect(r, p);

- canvas->saveLayer(&r, NULL, SkCanvas::kARGB_ClipLayer_SaveFlag);

+ canvas->saveLayer(&r, NULL);

draw_mode(canvas, mode, static_cast<SrcType>(sourceType),

r.fLeft, r.fTop);

canvas->restore();

« no previous file with comments | « bench/DeferredCanvasBench.cpp ('k') | gm/xfermodes2.cpp » ('j') | no next file with comments »