Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Issue 2414423003: Don't update progress when Frame::isLoading() is false (Closed)

Created:
4 years, 2 months ago by Nate Chapin
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Don't update progress when Frame::isLoading() is false This can lead to spurious progress change notifications, which can lead to underestimatation of progress, even at the time when the only page is complete. This was regressed in https://codereview.chromium.org/1860743002 BUG=650781 Review-Url: https://codereview.chromium.org/2412803004 Cr-Commit-Position: refs/heads/master@{#425178} (cherry picked from commit aa70a46d3bfff89100ab5732812dbb7a8dac7953) Committed: https://chromium.googlesource.com/chromium/src/+/931e8cb4d9bcc1a1864e8d513487b3eb36d2ecf8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M third_party/WebKit/Source/core/loader/ProgressTracker.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Nate Chapin
4 years, 2 months ago (2016-10-14 22:42:57 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
931e8cb4d9bcc1a1864e8d513487b3eb36d2ecf8.

Powered by Google App Engine
This is Rietveld 408576698