Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 2412803004: Don't update progress when Frame::isLoading() is false (Closed)

Created:
4 years, 2 months ago by Nate Chapin
Modified:
4 years, 2 months ago
Reviewers:
dcheng
CC:
Nate Chapin, blink-reviews, chromium-reviews, gavinp+loader_chromium.org, loading-reviews_chromium.org, tyoshino+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't update progress when Frame::isLoading() is false This can lead to spurious progress change notifications, which can lead to underestimatation of progress, even at the time when the only page is complete. This was regressed in https://codereview.chromium.org/1860743002 BUG=650781 Committed: https://crrev.com/aa70a46d3bfff89100ab5732812dbb7a8dac7953 Cr-Commit-Position: refs/heads/master@{#425178}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M third_party/WebKit/Source/core/loader/ProgressTracker.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Nate Chapin
4 years, 2 months ago (2016-10-13 20:23:23 UTC) #6
dcheng
lgtm
4 years, 2 months ago (2016-10-13 21:52:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2412803004/1
4 years, 2 months ago (2016-10-13 21:53:16 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-13 22:00:13 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 22:02:11 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aa70a46d3bfff89100ab5732812dbb7a8dac7953
Cr-Commit-Position: refs/heads/master@{#425178}

Powered by Google App Engine
This is Rietveld 408576698